1708710 - NTLM authentication for SMTP stopped to work since beta 89.0

Status: RESOLVED FIXED

(MailNews Core :: Networking: SMTP, defect)

Description

[Sergey]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/89.0.4389.128 Safari/537.36 Edg/89.0.774.77

Steps to reproduce:

Can't send mail after Thunderbird beta update

Actual results:

Response: 220 BTEX1.csi.local Microsoft ESMTP MAIL Service ready at Fri, 30 Apr 2021 07:16:25 -0400

Command Line: EHLO [192.168.235.250]

Simple Mail Transfer Protocol
Response: 250-BTEX1.csi.local Hello [38.32.26.50]
Response code: Requested mail action okay, completed (250)
Response parameter: BTEX1.csi.local Hello [38.32.26.50]
Response: 250-SIZE 10485760
Response code: Requested mail action okay, completed (250)
Response parameter: SIZE 10485760
Response: 250-PIPELINING
Response code: Requested mail action okay, completed (250)
Response parameter: PIPELINING
Response: 250-DSN
Response code: Requested mail action okay, completed (250)
Response parameter: DSN
Response: 250-ENHANCEDSTATUSCODES
Response code: Requested mail action okay, completed (250)
Response parameter: ENHANCEDSTATUSCODES
Response: 250-AUTH GSSAPI NTLM
Response code: Requested mail action okay, completed (250)
Response parameter: AUTH GSSAPI NTLM
Response: 250-8BITMIME
Response code: Requested mail action okay, completed (250)
Response parameter: 8BITMIME
Response: 250-BINARYMIME
Response code: Requested mail action okay, completed (250)
Response parameter: BINARYMIME
Response: 250 CHUNKING
Response code: Requested mail action okay, completed (250)
Response parameter: CHUNKING

Command Line: AUTH NTLM TlRMTVNTUAABAAAAB4IIAAAAAAAAAAAAAAAAAAAAAAA=

Response [truncated]: 334 TlRMTVNTUAACAAAABgAGADgAAAAFgokC...

Command Line: MAIL FROM:<[e-mail]> BODY=8BITMIME SIZE=438 RET=FULL ENVID=<[e-mail]>

Response: 535 5.7.3 Authentication unsuccessful

Expected results:

After
334 TlRMTVN...
auth string should be sent, like this:
Command Line [truncated]: TlRMTVNTUAADAAAAGAAYAFwAAACiAKIAdAAAA...

Comment 1

[Ping Chen [:rnons] (away)]

Attachment: Bug 1708710 - Fix command.success flag so that GSSAPI and NTLM auth work in SmtpClient.jsm. r=mkmelin

Bug 1704409 incorrectly set 3** status code as success, while GSSAPI and NTLM auth use 3** to communicate new challenges. Auth steps should continue until receiving 2** status code.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/3cf9bd922070
Fix command.success flag so that GSSAPI and NTLM auth work in SmtpClient.jsm. r=mkmelin

Comment 3

[Wayne Mery (:wsmwk)]

(In reply to Pulsebot from comment #2)

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/3cf9bd922070
Fix command.success flag so that GSSAPI and NTLM auth work in SmtpClient.jsm. r=mkmelin

Looks safe enough for beta?

Comment 4

[Ping Chen [:rnons] (away)]

Pretty safe.

Comment 5

[Magnus Melin [:mkmelin]]

Agreed this is low risk.

Comment 6

[Wayne Mery (:wsmwk)]

Comment on attachment 9219766 [details]
Bug 1708710 - Fix command.success flag so that GSSAPI and NTLM auth work in SmtpClient.jsm. r=mkmelin

[Triage Comment]
Approved for beta

Comment 7

[Rob Lemley [:rjl]]

Thunderbird 89.0b3:
https://hg.mozilla.org/releases/comm-beta/rev/3fe60445d97b