Simplify specifying JSWindowActor listeners which don't force actor creation
Categories
(Core :: DOM: Content Processes, enhancement, P2)
Tracking
()
Tracking | Status | |
---|---|---|
firefox90 | --- | fixed |
People
(Reporter: nika, Assigned: nika)
References
(Blocks 1 open bug)
Details
(Whiteboard: [fission-perf])
Attachments
(4 files)
Currently all event listeners specified for JSWindowActors always force creation of the actor when they are fired, however it appears to be a common pattern to use listeners like pagehide
or unload
to perform cleanup of a child-side actor. We should provide an option to request that one of these listeners should only be observed if the actor already exists to avoid these listeners creating actors as the page they're connected to is destroyed.
This may improve some navigation performance with fission by avoiding the unload
and pagehide
events causing the creation of the MarionetteEventsChild
, LinkHandlerChild
and AboutReaderChild
actors for the temporary initial about:blank document during process switches.
Updated•4 years ago
|
Updated•4 years ago
|
Comment 1•4 years ago
|
||
(In reply to Nika Layzell [:nika] (ni? for response) from comment #0)
This may improve some navigation performance with fission by avoiding the
unload
andpagehide
events causing the creation of theMarionetteEventsChild
,LinkHandlerChild
andAboutReaderChild
actors for the temporary initial about:blank document during process switches.
Please note that the navigation logic in Marionette actually requires the pagehide
event to be sent by the MarionetteEventsChild
actor. It is basically our initial signal that a new page navigation has been started. When this gets removed Marionette will hang on each and every page navigation.
Assignee | ||
Comment 2•3 years ago
|
||
Assignee | ||
Comment 3•3 years ago
|
||
Assignee | ||
Comment 4•3 years ago
|
||
Assignee | ||
Comment 5•3 years ago
|
||
Comment 7•3 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/e3a2ec3b19b4
https://hg.mozilla.org/mozilla-central/rev/93b3e76c8702
https://hg.mozilla.org/mozilla-central/rev/0849b7003a19
https://hg.mozilla.org/mozilla-central/rev/19653a51145c
Description
•