Closed Bug 1708735 Opened 2 years ago Closed 2 years ago

Make the arrow panel code more generic

Categories

(Toolkit :: Themes, defect, P5)

defect

Tracking

()

RESOLVED FIXED
91 Branch
Tracking Status
firefox91 --- fixed

People

(Reporter: emilio, Assigned: emilio)

References

(Blocks 2 open bugs)

Details

(Keywords: perf-alert, Whiteboard: [proton-cleanup])

Attachments

(1 file)

Share the concept of a panel content with all other menupopups / panels. This shouldn't change behavior but makes bug 1708136 a matter of tweaking a couple CSS rules and fixing up test failures.

Share the concept of a panel content with all other menupopups / panels.

This avoids importing global.css in the shadow tree, and renames the
arrowcontent part to just "content", since we want to introduce a
"content" part for other panels.

This shouldn't change behavior but makes bug 1708136 a matter of
tweaking a couple CSS rules and fixing up test failures.

Assignee: nobody → emilio
Status: NEW → ASSIGNED
Attachment #9219571 - Attachment description: Bug 1708136 - Make the arrowpanel code more generic. r=dao → Bug 1708735 - Make the arrowpanel code more generic. r=dao
Blocks: 1708835
Depends on: 1710486
Depends on: 1710533
Blocks: 1710612
Whiteboard: [proton-cleanup]
Priority: -- → P5
Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/229e905d571e
Make the arrowpanel code more generic. r=dao,zombie
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 90 Branch
Regressions: 1713463
Regressions: 1713469

Backed out for causing multiple regressions.

Status: RESOLVED → REOPENED
Flags: needinfo?(emilio)
Resolution: FIXED → ---
Target Milestone: 90 Branch → ---
Backout by abutkovits@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/4bda89ab5cd7
Backed out changeset 229e905d571e for multiple regressions. CLOSED TREE
Attachment #9219571 - Attachment description: Bug 1708735 - Make the arrowpanel code more generic. r=dao → WIP: Bug 1708735 - Make the arrowpanel code more generic. r=dao,zombie
Attachment #9219571 - Attachment description: WIP: Bug 1708735 - Make the arrowpanel code more generic. r=dao,zombie → Bug 1708735 - Make the arrowpanel code more generic. r=dao,zombie
Flags: needinfo?(emilio)
Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e1a42874f276
Make the arrowpanel code more generic. r=dao,zombie
Status: REOPENED → RESOLVED
Closed: 2 years ago2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 90 Branch
Regressions: 1713516
Regressions: 1713563

Backed out of beta after today's merge so the regressions can be addressed for 91.

Backed out 1 changesets (bug 1708735) for multiple regressions
https://hg.mozilla.org/releases/mozilla-beta/rev/423fdcd1498c7386d03325fdff703639f76b1b4a

See Also: → 1713436
Regressions: 1713777

(In reply to Julien Cristau [:jcristau] from comment #8)

Backed out of beta after today's merge so the regressions can be addressed for 91.

Backed out 1 changesets (bug 1708735) for multiple regressions
https://hg.mozilla.org/releases/mozilla-beta/rev/423fdcd1498c7386d03325fdff703639f76b1b4a

Thanks, this was definitely the right call. I thought we were no longer in the soft freeze, my bad.

(In reply to Pulsebot from comment #2)

Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/229e905d571e
Make the arrowpanel code more generic. r=dao,zombie

== Change summary for alert #30252 (as of Sun, 30 May 2021 14:41:04 GMT) ==

Improvements:

Ratio Suite Test Platform Options Absolute values (old vs new)
3% tresize (docs) macosx1015-64-shippable-qr e10s stylo webrender 7.06 -> 6.84
2% tresize (docs) macosx1015-64-shippable e10s stylo 8.95 -> 8.77

For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=30252

Regressions: 1714000
Target Milestone: 90 Branch → 91 Branch
Regressions: 1714949
Regressions: 1715139
Regressions: 1716617
Regressions: 1717225
Regressions: 1722621
You need to log in before you can comment on or make changes to this bug.