1708735 - Make the arrow panel code more generic

Status: RESOLVED FIXED

(Toolkit :: Themes, defect, P5)

Description

[Emilio Cobos Álvarez [:emilio]]

Share the concept of a panel content with all other menupopups / panels. This shouldn't change behavior but makes bug 1708136 a matter of tweaking a couple CSS rules and fixing up test failures.

Comment 1

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1708735 - Make the arrowpanel code more generic. r=dao,zombie

Share the concept of a panel content with all other menupopups / panels.

This avoids importing global.css in the shadow tree, and renames the
arrowcontent part to just "content", since we want to introduce a
"content" part for other panels.

This shouldn't change behavior but makes bug 1708136 a matter of
tweaking a couple CSS rules and fixing up test failures.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/229e905d571e
Make the arrowpanel code more generic. r=dao,zombie

Comment 3

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/229e905d571e

Comment 4

[Atila Butkovits]

Backed out for causing multiple regressions.

Comment 5

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4bda89ab5cd7
Backed out changeset 229e905d571e for multiple regressions. CLOSED TREE

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e1a42874f276
Make the arrowpanel code more generic. r=dao,zombie

Comment 7

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/e1a42874f276

Comment 8

[Julien Cristau [:jcristau] (back August 18)]

Backed out of beta after today's merge so the regressions can be addressed for 91.

Backed out 1 changesets (bug 1708735) for multiple regressions
https://hg.mozilla.org/releases/mozilla-beta/rev/423fdcd1498c7386d03325fdff703639f76b1b4a

Comment 9

[Emilio Cobos Álvarez [:emilio]]

(In reply to Julien Cristau [:jcristau] from comment #8)

Backed out of beta after today's merge so the regressions can be addressed for 91.

Backed out 1 changesets (bug 1708735) for multiple regressions
https://hg.mozilla.org/releases/mozilla-beta/rev/423fdcd1498c7386d03325fdff703639f76b1b4a

Thanks, this was definitely the right call. I thought we were no longer in the soft freeze, my bad.

Comment 10

[Alexandru Ionescu (needinfo me) [:alexandrui]]

(In reply to Pulsebot from comment #2)

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/229e905d571e
Make the arrowpanel code more generic. r=dao,zombie

== Change summary for alert #30252 (as of Sun, 30 May 2021 14:41:04 GMT) ==

Improvements:

Ratio	Suite	Test	Platform	Options	Absolute values (old vs new)
3%	tresize (docs)		macosx1015-64-shippable-qr	e10s stylo webrender	7.06 -> 6.84
2%	tresize (docs)		macosx1015-64-shippable	e10s stylo	8.95 -> 8.77

For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=30252