Closed Bug 170876 Opened 23 years ago Closed 23 years ago

allow plugin logging in release builds in all files

Categories

(Core Graveyard :: Plug-ins, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla1.2beta

People

(Reporter: peterlubczynski-bugs, Assigned: peterl-bugs)

Details

(Whiteboard: [PL2:NA])

Attachments

(1 file)

Currently plugin logging works in release builds in nsPluginHostImpl.cpp because FORCE_PR_LOG is defined. I propose to move it to nsPluginLogging.h so that all plugin files will get logged in release builds (which will help us debug bugs easier).
Attached patch patch v.1Splinter Review
Status: NEW → ASSIGNED
Keywords: patch, review
Whiteboard: [PL2:NA]
Target Milestone: --- → mozilla1.2beta
Comment on attachment 100677 [details] [diff] [review] patch v.1 r=serge
Attachment #100677 - Flags: review+
Comment on attachment 100677 [details] [diff] [review] patch v.1 sr=alecf do we want to turn this off before shipping or anything, to reduce code bloat?
Attachment #100677 - Flags: superreview+
patch checked in, marking FIXED. See bug 55999 about removing FORCE_PR_LOG to reduce footprint. I tried the bits from Netscape.com and I was amazed at how much gets outputed to my console by many modules: set NSPR_LOG_MODULES=all:5 netscp.exe -console
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: