Closed Bug 1708781 Opened 3 years ago Closed 3 years ago

Update the 'Delete' and 'Error' icons

Categories

(Toolkit :: Themes, enhancement)

Product:
Toolkit
Component:
Themes
Type:
enhancement

Tracking

()

Status:
VERIFIED FIXED
Milestone:
90 Branch
Tracking Flags:
Tracking Status
firefox89 --- verified
firefox90 --- verified

People

(Reporter: jaws, Assigned: jaws)

References

(Blocks 1 open bug)

Details

(Whiteboard: [proton-icons] [proton-uplift])

Attachments

(1 file)

Bug 1708781 - Update 'Error' and 'Delete' icons.
48 bytes, text/x-phabricator-request
pascalc
: approval-mozilla-beta+
Details | Review

STR:

  1. Open about:logins, add a login, and click on the login. The trash can icon should be updated
  2. Go to about:blocked, the tab's favicon should be updated

Comment on attachment 9219592 [details]
Bug 1708781 - Update 'Error' and 'Delete' icons.

Beta/Release Uplift Approval Request

  • User impact if declined: Required for Proton / MR1
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: No
  • Needs manual test from QE?: Yes
  • If yes, steps to reproduce: See https://bugzilla.mozilla.org/show_bug.cgi?id=1708781#c0
  • List of other uplifts needed: none
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Icon-only change
  • String changes made/needed: none
Attachment #9219592 - Flags: approval-mozilla-beta?
Flags: qe-verify+
Pushed by jwein@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/87a338579599
Update 'Error' and 'Delete' icons. r=sfoster

https://hg.mozilla.org/mozilla-central/rev/87a338579599

Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox90: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 90 Branch
Whiteboard: [proton-icons] → [proton-icons] [proton-uplift]

Comment on attachment 9219592 [details]
Bug 1708781 - Update 'Error' and 'Delete' icons.

Low risk icon swap for Proton, uplift approved for 89 beta 8, thanks.

Attachment #9219592 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
QA Whiteboard: [qa-triaged]

Verified as fixed on Windows 10 x64, macOS 10.15, Ubuntu 20.04 and on Windows 7 x64.

Status: RESOLVED → VERIFIED
QA Whiteboard: [qa-triaged]
status-firefox89: fixed → verified
status-firefox90: fixed → verified
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: