Open Bug 1708802 Opened 3 years ago Updated 2 years ago

UITour should not iterate through all browser windows for every closed tab

Categories

(Firefox :: Tours, defect)

Product:
Firefox
Component:
Tours
Type:
defect

Tracking

()

Project Flags:
Performance Impact low

People

(Reporter: florian, Unassigned)

References

(Blocks 1 open bug)

Details

(Keywords: perf:frontend, perf:responsiveness)

I captured a profile of closing a bit more than 300 tabs, and UITour looping over every browser window for every "message-manager-close" observer notification repesented about 7% of the time: https://share.firefox.dev/3nBspwF

Whiteboard: [fxperf] → [fxperf:p2]
Severity: -- → S3

If didDestroy works reliably (I recall some actor teardown methods didn't work reliably a few years ago) then it can probably be used in its actor instead: https://searchfox.org/mozilla-central/rev/6deb8b6af57a8b5b6b1bcb143ea498e566475d8d/browser/components/uitour/UITourParent.jsm#9-10

Performance Impact: --- → ?
Keywords: perf:frontend, perf:responsiveness
Whiteboard: [fxperf:p2]
Performance Impact: ? → P3
You need to log in before you can comment on or make changes to this bug.