1708835 - Popup menus inconsistent with GTK theme

Status: RESOLVED WORKSFORME

(Toolkit :: Themes, defect)

Description

[Jan Alexander Steffens [:heftig]]

Attachment: Firefox (left) and native GTK (right), 2× scale, Adwaita dark

The popup menus attempt to emulate the style of native popup menus, but differ in several ways:

• Border is different
  • Color is different
  • Width is different
  • Shadow is missing (hard to tell)
  • Corners are square instead of rounded
• Overall menu padding is too small
  • GTK popups seem to have 4 px more padding
• Menu item padding is too small
  • Baseline-to-baseline distance is 26 px for Firefox and 27 px for GTK

It would be nice if the popup menus were consistent with the native GTK theme. That said, I would prefer for Firefox to be self-consistent and have popup menus matching the design of the hamburger menu.

Comment 1

[Martin Stránský [:stransky] (ni? me)]

It's because Gtk toolkit does not get/export styles form popup menu borders so we don't paint the round corners for popups. We also draw all menuitem text entries in active state - I don't think Firefox puts inactive entries to popup menus.

Comment 2

[Jan Alexander Steffens [:heftig]]

(In reply to Martin Stránský [:stransky] (ni? me) from comment #1)

It's because Gtk toolkit does not get/export styles form popup menu borders so we don't paint the round corners for popups. We also draw all menuitem text entries in active state - I don't think Firefox puts inactive entries to popup menus.

You mean disabled entries? It does. For example, the last tab will have disabled "Move to End" and "Close Tabs to Right" entries in the "Move Tab" resp. "Close Multiple Tabs" submenus. In an input field, Undo/Redo and the selection entries are contextually disabled.

Comment 3

[Dão Gottwald [:dao]]

Emilio, is this a duplicate of bug 1828413?

Comment 4

[Emilio Cobos Álvarez (:emilio)]

Somewhat, bug 1828413 makes the menus look more like GTK4, and less weird in some themes. Jan, maybe we can close this? We have some WIP support for native menus (widget.gtk.native-context-menus), but I don't think we want to pursue it necessarily.

Comment 5

[Jan Alexander Steffens [:heftig]]

I guess. Item padding still seems too low compared to menus in gtk3-demo but there's no padding difference compared to the experimental widget.gtk.native-context-menus so not sure what's going on.

Comment 6

[Dão Gottwald [:dao]]

This should work okay now based on the work in bug 1828413 and related bugs.

Comment 7

[Dão Gottwald [:dao]]

I did file bug 1833124 on potentially improving our platform integration here.