Closed Bug 1709076 Opened 3 years ago Closed 3 years ago

Reload symbol off-center in customise toolbar screen

Categories

(Firefox :: Toolbars and Customization, defect, P3)

Firefox 90
defect

Tracking

()

VERIFIED FIXED
90 Branch
Tracking Status
firefox-esr78 --- unaffected
firefox88 --- unaffected
firefox89 --- wontfix
firefox90 --- verified

People

(Reporter: fosterjamesbenjaminmail+bugzilla, Assigned: molly)

References

(Blocks 1 open bug, Regression)

Details

(Keywords: regression, Whiteboard: [proton-toolbar])

Attachments

(2 files)

Attached image firefox_NWfSG67aq3.png

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:90.0) Gecko/20100101 Firefox/90.0

Steps to reproduce:

Go into the "Customise Toolbar" screen
Remove Reload from the Toolbar
The reload symbol will be off center

Actual results:

The reload symbol will be off center

Expected results:

The symbol should be centeral and the size should match the others.

The Bugbug bot thinks this bug should belong to the 'Firefox::Toolbars and Customization' component, and is moving the bug to that component. Please revert this change in case you think the bot is wrong.

Component: Untriaged → Toolbars and Customization
Status: UNCONFIRMED → NEW
Ever confirmed: true
Flags: needinfo?(mhowell)
Regressed by: 1698436
Whiteboard: [proton-toolbar]
Has Regression Range: --- → yes

Yeah, I definitely caused this in bug 1698436. I see how to fix it.

Assignee: nobody → mhowell
Status: NEW → ASSIGNED
Flags: needinfo?(mhowell)
Severity: -- → S4
Priority: -- → P3
Pushed by mhowell@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a024b4a81628
Keep the reload button centered when in the customize palette. r=jaws
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 90 Branch

Set release status flags based on info from the regressing bug 1698436

Comment on attachment 9219866 [details]
Bug 1709076 - Keep the reload button centered when in the customize palette. r=#desktop-theme-reviewers

Beta/Release Uplift Approval Request

  • User impact if declined: See the attached screenshot. This is a cosmetic bug, but it does look pretty bad, and it's an MR1 regression.
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): The fix is a tiny CSS change that only applies to this one button and only when in the customize palette.
  • String changes made/needed:
Attachment #9219866 - Flags: approval-mozilla-beta?

Comment on attachment 9219866 [details]
Bug 1709076 - Keep the reload button centered when in the customize palette. r=#desktop-theme-reviewers

Marked as wontfix for MR1.

Attachment #9219866 - Flags: approval-mozilla-beta? → approval-mozilla-beta-

Verified that the reload icon issue is fixed on Firefox 90.0a1 (2021-05-18) under macOS 11.3.1, Windows 10 and Ubuntu 20.04.

Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: