Closed Bug 1709086 Opened 4 years ago Closed 3 years ago

[Linux] Password Manager prompt displays white text on white background with `ui.systemUsesDarkTheme=1`

Categories

(Firefox :: Theme, defect)

Desktop
Linux
defect

Tracking

()

RESOLVED WONTFIX

People

(Reporter: nbp, Unassigned)

Details

(Keywords: regression, regressionwindow-wanted)

Attachments

(2 files)

Attached image Password Manager Prompt

When setting ui.systemUsesDarkTheme=1 (to fake system dark mode), the password manager prompt is unusable, as the buttons/input are displaying white text on white background. (see attachement)

The buttons and input area should probably have a dark background.

Flags: needinfo?(dao+bmo)
Severity: -- → S2
QA Whiteboard: [qa-regression-triage]

I can't reproduce this on macOS (which is what the summary suggests) or on Linux (which is what the screenshot looks like to me).

Maybe this went away, what with all of Emilio's fixes for dark mode generally? Or maybe it depends on the Linux window manager theme?

Severity: S2 → --
Flags: needinfo?(nicolas.b.pierron)

I am still able to reproduce this issue on Linux with the latest Nightly.

STR:

  • Execute firefox -P bug1709086 --no-remote
  • Create a new profile, and start it.
  • Open about:config
  • Add a new preference ui.systemUsesDarkTheme as a Number and set it to 1.
  • Open the settings panel.
  • Search for password and check the box Use a Primary Password.
  • Use test as a master password.
  • [see attached image]

In terms of Linux theme, I am using the Awersome Window Manager, and I have not configured any GTK / KDE theme. The default theme inferred is not a dark theme.

I do not have any ~/.gtkrc-2.0, the only gtk settings are:

/home/nicolas/.config/gtk-2.0/gtkfilechooser.ini
/home/nicolas/.config/gtk-3.0/custom-papers

Running strace -z -e trace=file … and filtering any opened path with gtk in it reports:

/nix/store/hmnzfjgxrcccajalj6vqaa42kk5m1823-firefox-release-bin-unwrapped-96.0a1/usr/lib/firefox-bin-96.0a1/libmozgtk.so
/nix/store/hmnzfjgxrcccajalj6vqaa42kk5m1823-firefox-release-bin-unwrapped-96.0a1/usr/lib/firefox-bin-96.0a1/libmozgtk.so
/nix/store/g2xxryy86xk29p8dgxggzz1q3qb1bhcm-gtk+3-3.24.30/lib/libgtk-3.so.0
/nix/store/g2xxryy86xk29p8dgxggzz1q3qb1bhcm-gtk+3-3.24.30/lib/libgdk-3.so.0
/nix/store/g2xxryy86xk29p8dgxggzz1q3qb1bhcm-gtk+3-3.24.30/share/locale/en/LC_MESSAGES/gtk30.mo
/nix/store/g2xxryy86xk29p8dgxggzz1q3qb1bhcm-gtk+3-3.24.30/share/locale/en/LC_MESSAGES/gtk30-properties.mo
/nix/store/g2xxryy86xk29p8dgxggzz1q3qb1bhcm-gtk+3-3.24.30/share/icons/hicolor/16x16/apps
/nix/store/g2xxryy86xk29p8dgxggzz1q3qb1bhcm-gtk+3-3.24.30/share/icons/hicolor/22x22/apps
/nix/store/g2xxryy86xk29p8dgxggzz1q3qb1bhcm-gtk+3-3.24.30/share/icons/hicolor/24x24/apps
/nix/store/g2xxryy86xk29p8dgxggzz1q3qb1bhcm-gtk+3-3.24.30/share/icons/hicolor/32x32/apps
/nix/store/g2xxryy86xk29p8dgxggzz1q3qb1bhcm-gtk+3-3.24.30/share/icons/hicolor/48x48/apps
/nix/store/g2xxryy86xk29p8dgxggzz1q3qb1bhcm-gtk+3-3.24.30/share/icons/hicolor/256x256/apps
/nix/store/g2xxryy86xk29p8dgxggzz1q3qb1bhcm-gtk+3-3.24.30/share/icons
/nix/store/g2xxryy86xk29p8dgxggzz1q3qb1bhcm-gtk+3-3.24.30/lib/gtk-3.0/3.0.0/immodules.cache
/nix/store/g2xxryy86xk29p8dgxggzz1q3qb1bhcm-gtk+3-3.24.30/share/gsettings-schemas/gtk+3-3.24.30/glib-2.0/schemas/gschemas.compiled
/nix/store/g2xxryy86xk29p8dgxggzz1q3qb1bhcm-gtk+3-3.24.30/share/gsettings-schemas/gtk+3-3.24.30/glib-2.0/schemas/gschemas.compiled
/nix/store/g2xxryy86xk29p8dgxggzz1q3qb1bhcm-gtk+3-3.24.30/share/applications

Flags: needinfo?(nicolas.b.pierron)
Summary: Password Manager prompt display white text on white background with `ui.systemUsesDarkTheme=1` (unusable at night on macs) → [Linux] Password Manager prompt displays white text on white background with `ui.systemUsesDarkTheme=1`
OS: Unspecified → Linux
Hardware: Unspecified → Desktop

(In reply to Nicolas B. Pierron [:nbp] from comment #5)

In terms of Linux theme, I am using the Awersome Window Manager, and I have not configured any GTK / KDE theme. The default theme inferred is not a dark theme.

I don't know how to replicate this situation - not without spending hours setting up an entire new Linux VM. It works fine under my environment.

The button in the dialog in your last screenshot (which is different from the one that came with comment 0 - is it definitely the same issue?) has color: ButtonText, and gets a button appearance set as well (which should set the background), so that should result in readable text based on what buttons normally look like in your OS theme. I don't know how to determine why it doesn't in your environment, given that I can't reproduce. I expect the pref is involved, but I don't know how. Emilio, can you help?

Flags: needinfo?(emilio)

(In reply to :Gijs (he/him) from comment #6)

I don't know how to replicate this situation - not without spending hours setting up an entire new Linux VM. It works fine under my environment.

If needed, I might be able to generate a VM which replicates the issue.

The button in the dialog in your last screenshot (which is different from the one that came with comment 0 - is it definitely the same issue?) […]

Yes, this looks like the same issue. I can reproduce the original screenshot if I attempt to add a new password in about:logins, where I am prompted to enter the master password.

My guess would be that this prompt is handled by the system and not by Firefox, and by setting the preference, we assume the system to have a dark-mode enabled where it does not.

I will also note that the reason for finding this preference was that the dark-mode did not apply to Firefox UI at the time.
Which has now been fixed by Emilio.

Thus, I am ok to mark this bug as WONTFIX.

Yeah, note that ui.systemUsesDarkMode should not be overridden. If you want to change prefers-color-scheme for content there's layout.css.prefers-color-scheme.content-override, and the Firefox UI should do the right thing.

Status: NEW → RESOLVED
Closed: 3 years ago
Flags: needinfo?(emilio)
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: