1709139 - Change existing JS_*_PROPORTION probes to measure absolute time instead

Status: RESOLVED FIXED

(Core :: Performance: General, defect, P3)

Description

[Denis Palmeiro [:denispal]]

The existing probes are expired, but we'd like to keep them in a different form which measures absolute time instead.

JS_EXECUTION_PROPORTION
JS_DELAZIFICATION_PROPORTION
JS_XDR_ENCODING_PROPORTION
JS_BASELINE_COMPILE_PROPORTION

Comment 1

[Denis Palmeiro [:denispal]]

Attachment: Replace JS pageload proportion probes with absolute time measurements and add new probes to measure GC and main thread parsing impact during page load.

Replace JS pageload proportion probes with absolute time measurements and add new probes to measure GC and main thread parsing impact during page load.

Comment 2

[Denis Palmeiro [:denispal]]

Attachment: data-review-1709139.md

Comment 3

[Denis Palmeiro [:denispal]]

Attachment: data-review-1709139.md

Comment 4

[Chris H-C :chutten]

Comment on attachment 9220654 [details]
data-review-1709139.md

DATA COLLECTION REVIEW RESPONSE:

Is there or will there be documentation that describes the schema for the ultimate data set available publicly, complete and accurate?

Yes.

Is there a control mechanism that allows the user to turn the data collection on and off?

Yes. This collection is Telemetry so can be controlled through Firefox's Preferences.

If the request is for permanent data collection, is there someone who will monitor the data over time?

Yes, Denis Palmeiro is responsible.

Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Category 1, Technical.

Is the data collection request for default-on or default-off?

Default on for all channels.

Does the instrumentation include the addition of any new identifiers?

No.

Is the data collection covered by the existing Firefox privacy notice?

Yes.

Does there need to be a check-in in the future to determine whether to renew the data?

No. This collection is permanent.

---

Result: datareview+

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/460cb4efc41e
Replace JS pageload proportion probes with absolute time measurements and add new probes to measure GC and main thread parsing impact during page load. r=sfink,iain,smaug

Comment 6

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/460cb4efc41e