Closed Bug 1709163 Opened 5 years ago Closed 4 years ago

update to falcon 3.0.0

Categories

(Socorro :: Antenna, task, P2)

Product:
Socorro
Component:
Antenna
Type:
task

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: willkg, Assigned: willkg)

Details

Antenna uses Falcon 2.0.0 right now. Falcon 3.0.0 came out--we should upgrade.

While upgrading, we can fix bug #1562641.

Grabbing this to do soon.

Assignee: nobody → willkg
Status: NEW → ASSIGNED

Bumping bugs off my queue because I'm not going to get to them any time soon.

Assignee: willkg → nobody
Status: ASSIGNED → NEW

I inadvertently did this in pull 769.

https://github.com/mozilla-services/antenna/pull/769

Changelog is here: https://falcon.readthedocs.io/en/3.0.0/changes/3.0.0.html

There are some follow-up changes we should make:

  • switch from response.body to response.text

    Rename falcon.Response.body and falcon.HTTPStatus.body to text. The old name is deprecated, but still available. (#1578)

  • verify unhandled exceptions get sent to sentry

  • look at switching to MultipartFormHandler

    MultipartFormHandler was added to enable support for multipart forms (of content type multipart/form-data) through falcon.Request.get_media(). (#953)

  • switch from falcon.API to falcon.App

    The falcon.API class was renamed to falcon.App. The old API class remains available as an alias for backwards-compatibility, but it is now considered deprecated and will be removed in a future release. (#1579)

Grabbing this to work on soon.

Assignee: nobody → willkg
Status: NEW → ASSIGNED

I did a bunch of these in PR 778: https://github.com/mozilla-services/antenna/pull/778

The one thing we didn't do is switch to MultipartFormHandler. That's covered in bug #1562641.

Given that, I'm closing this out.

Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.