Closed Bug 1709172 Opened 7 months ago Closed 7 months ago

Dont show the download icon in the start-download animation when the button is currently hidden in the toolbar.

Categories

(Firefox :: Theme, enhancement, P2)

enhancement

Tracking

()

RESOLVED FIXED
90 Branch
Tracking Status
firefox89 --- fixed
firefox90 --- fixed

People

(Reporter: sfoster, Assigned: sfoster)

References

(Blocks 1 open bug)

Details

(Whiteboard: [proton-icons] [priority:2a] [proton-uplift])

Attachments

(1 file)

The default behavior is to hide the download toolbar button and only show it in the toolbar when a download happens or there are contents in the download panel.

The new download start animation includes the icon in the first few frames, so it appears to flash in and them disappear quickly as it transitions to the progress circle.

In the initial download case, we should remove the icon from those first few frames.

Assignee: nobody → sfoster
Status: NEW → ASSIGNED
Priority: -- → P2
Whiteboard: [proton-icons] → [proton-icons] [priority:2a]

I've filed bug 1709904 and bug 1709902 to follow up on the issues Gijs identified in review.

Pushed by sfoster@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8a9f8d02f9f3
Add a washidden attribute on #downloads-button; adjust fill color in start animation based on state we are animating from. r=Gijs
Status: ASSIGNED → RESOLVED
Closed: 7 months ago
Resolution: --- → FIXED
Target Milestone: --- → 90 Branch

Request for Uplift from the PM team

Comment on attachment 9220243 [details]
Bug 1709172 - Add a washidden attribute on #downloads-button; adjust fill color in start animation based on state we are animating from. r?Gijs

Beta/Release Uplift Approval Request

  • User impact if declined: Flickery download animation for the first download in every session
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: No
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: n/a
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Relatively small changes to JS, CSS and image assets, has baked on nightly for a decent while now, applies completely cleanly to beta branch.
  • String changes made/needed: Nope
Attachment #9220243 - Flags: approval-mozilla-beta?
Whiteboard: [proton-icons] [priority:2a] → [proton-icons] [priority:2a] [proton-uplift]

Comment on attachment 9220243 [details]
Bug 1709172 - Add a washidden attribute on #downloads-button; adjust fill color in start animation based on state we are animating from. r?Gijs

Approved for 89 beta 15, thanks.

Attachment #9220243 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.