1709204 - Shortcut modal - Implement Firefox favicon to dialog title

Status: RESOLVED WONTFIX

(Firefox :: New Tab Page, enhancement, P3)

Description

[Amy Churchwell [:amy]]

Change shortcut modal title position in dialog and include Firefox favicon. (See URL for figma spec)

Comment 1

[Amy Churchwell [:amy]]

Attachment: favicon-spec.png

Attaching a screenshot of the spec in case figma is only viewable by employees.
Annotated with a red square around what we would like to update.

Comment 2

[Amy Churchwell [:amy]]

I believe we need a rule in this block.

If a contributor works on this, note that you will have to bundle the CSS before you can see your changes. Run ./mach npm run bundle --prefix=browser/components/newtab. More information here.

Comment 3

[Amy Churchwell [:amy]]

Hi Julian, do you know where a small Firefox favicon lives in the code base? There doesn't seem to be anything in browser/components/newtab/data/content/assets that works for this. Or do you know who would know? (firefox.svg is the tail swoosh logo, not the browser logo, sadly.)

Comment 4

[Falguni Islam]

Hello I am an accepted outreachy applicant I am looking for good first bug can I work on this bug?

Comment 5

[Julian Gaibler]

Hi Amy,
all the branded stuff lives in mozilla-central/browser/branding/official (or the other directories, depending on the build). So I'd guess what you need would live in there?

Comment 6

[onuohaoluebube05]

Hello Amy, permit me to contribute to this project.

Thanks

Comment 7

[Amy Churchwell [:amy]]

(In reply to Falguni Islam from comment #4)

Hello I am an accepted outreachy applicant I am looking for good first bug can I work on this bug?

Hello and welcome! You may work on this, I'll assign you. Don't hesitate to let me know if you have any questions.

Comment 8

[Falguni Islam]

OK Thank you very much

Comment 9

[Falguni Islam]

Attachment: Bug 1709204 : shortcut modal- Implement Firefox favicon to dialog title

Comment 10

[Amy Churchwell [:amy]]

Hi there, did you have any trouble installing the dependencies?

Comment 11

[BugBot [:suhaib / :marco/ :calixte]]

This good-first-bug hasn't had any activity for 2 months, it is automatically unassigned.
For more information, please visit auto_nag documentation.

Comment 12

[Janvi Bajoria [:janvi01]]

Hey! I want to work on this issue if it is still available.

Comment 13

[samuraix221]

Can I be assigned to this bug? Or is someone already working on this?

Comment 14

[samuraix221]

Attachment: Bug 1709204 - shortcut modal- Implement Firefox favicon to dialog title r?amy

Comment 15

[BugBot [:suhaib / :marco/ :calixte]]

Redirect a needinfo that is pending on an inactive user to the triage owner.
:daleharvey, since the bug has recent activity, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 16

[BugBot [:suhaib / :marco/ :calixte]]

The bug assignee is inactive on Bugzilla, so the assignee is being reset.

Comment 17

[aritra :ari]

It's my first time contributing to Open Source, can I try to fix this bug?

Comment 18

[Amy Churchwell [:amy]]

Closing all remaining bugs under https://bugzilla.mozilla.org/show_bug.cgi?id=1707989 per request from product.