Closed Bug 1709215 Opened 4 years ago Closed 4 years ago

[wpt-sync] Sync PR 28802 - Implement colorMatrix filters for CanvasFilter objects

Categories

(Core :: DOM: Core & HTML, task, P4)

task

Tracking

()

RESOLVED FIXED
90 Branch
Tracking Status
firefox90 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 28802 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/28802
Details from upstream follow.

b'Aaron Krajeski <aaronhk@chromium.org>' wrote:

Implement colorMatrix filters for CanvasFilter objects

The existing SVG interface has been copied exactly, even when it doesn't
make a ton of sense, for example:
ctx.filter = new CanvasFilter({colorMatrix: {type: "saturate", values: 0.5}});
Uses the key "values" instead of "value", even though it's only a single
number.

Bug: 1169216
Change-Id: I6242f1909645ee4a2f7a6258b6563b44f3eb76eb
Reviewed-on: https://chromium-review.googlesource.com/2855935
WPT-Export-Revision: 29ab304ca906e2695cb59a069234d7932631e843

Whiteboard: [wptsync downstream] → [wptsync downstream error]
Component: web-platform-tests → DOM: Core & HTML
Product: Testing → Core
Whiteboard: [wptsync downstream error] → [wptsync downstream]

CI Results

Ran 15 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 3 tests and 1 subtests

Status Summary

Firefox

OK : 3
FAIL: 3

Chrome

OK : 3
FAIL: 3

Safari

OK : 3
FAIL: 3

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/html/canvas/element/filters/2d.filter.canvasFilterObject.colorMatrix.html
Test the functionality of ColorMatrix filters in CanvasFilter objects: FAIL (Chrome: FAIL, Safari: FAIL)
/html/canvas/offscreen/filters/2d.filter.canvasFilterObject.colorMatrix.html
Test the functionality of ColorMatrix filters in CanvasFilter objects: FAIL (Chrome: FAIL, Safari: FAIL)
/html/canvas/offscreen/filters/2d.filter.canvasFilterObject.colorMatrix.worker.html
Test the functionality of ColorMatrix filters in CanvasFilter objects: FAIL (Chrome: FAIL, Safari: FAIL)

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/bd1364866b05 [wpt PR 28802] - Implement colorMatrix filters for CanvasFilter objects, a=testonly https://hg.mozilla.org/integration/autoland/rev/90275ff9f480 [wpt PR 28802] - Update wpt metadata, a=testonly
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 90 Branch
You need to log in before you can comment on or make changes to this bug.