1709295 - 33.73 - 9.02% ts_paint / startup_about_home_paint + 13 more (Linux) regression on Fri April 30 2021

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect)

Description

[Alexandru Ionescu (needinfo me) [:alexandrui]]

Perfherder has detected a talos performance regression from push a57a18bd5034b718955a35fecea22727d556e35f. As author of one of the patches included in that push, we need your help to address this regression.

Regressions:

Ratio	Suite	Test	Platform	Options	Absolute values (old vs new)
34%	ts_paint (docs)	ts_paint	linux1804-64-shippable-qr	e10s stylo webrender-sw	215.79 -> 288.58
33%	ts_paint (docs)	ts_paint	linux1804-64-shippable	e10s stylo	216.62 -> 288.17
33%	ts_paint_webext (docs)	ts_paint_webext	linux1804-64-shippable-qr	e10s stylo webrender-sw	221.67 -> 293.75
32%	ts_paint_webext (docs)	ts_paint_webext	linux1804-64-shippable	e10s stylo	218.96 -> 289.42
30%	ts_paint_webext (docs)	ts_paint_webext	linux1804-64-shippable-qr	e10s stylo webrender	252.50 -> 328.58
29%	ts_paint_webext (docs)	ts_paint_webext	linux1804-64-shippable-qr	e10s stylo webrender	253.08 -> 325.92
28%	ts_paint (docs)	ts_paint	linux1804-64-shippable-qr	e10s stylo webrender	252.83 -> 322.42
14%	sessionrestore_no_auto_restore (docs)	sessionrestore_no_auto_restore	linux1804-64-shippable	e10s stylo	573.00 -> 652.75
14%	sessionrestore (docs)	sessionrestore	linux1804-64-shippable-qr	e10s stylo webrender-sw	489.08 -> 556.42
13%	sessionrestore (docs)	sessionrestore	linux1804-64-shippable	e10s stylo	515.38 -> 583.42
12%	sessionrestore (docs)	sessionrestore	linux1804-64-shippable-qr	e10s stylo webrender	525.46 -> 586.58
12%	startup_about_home_paint_realworld_webextensions (docs)	startup_about_home_paint_realworld_webextensions	linux1804-64-shippable	e10s stylo	651.83 -> 727.25
11%	startup_about_home_paint (docs)	startup_about_home_paint	linux1804-64-shippable	e10s stylo	650.79 -> 722.33
10%	startup_about_home_paint (docs)	startup_about_home_paint	linux1804-64-shippable-qr	e10s stylo webrender-sw	651.00 -> 717.50
9%	startup_about_home_paint (docs)	startup_about_home_paint	linux1804-64-shippable-qr	e10s stylo webrender	690.29 -> 752.58

Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests. Please follow our guide to handling regression bugs and let us know your plans within 3 business days, or the offending patch(es) will be backed out in accordance with our regression policy.

For more information on performance sheriffing please see our FAQ.

Comment 1

[Emilio Cobos Álvarez (:emilio)]

We'll have to pay this startup performance hit at some point (and we were paying it already for users with dark themes), but since we're not just using it just yet I can put it behind a pref I guess.

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1709295 - Keep dark system color extraction behind a pref for now. r=stransky

We'll have to pay this startup time penalty eventually for light theme
users as well but, until we do, we can avoid this regression.

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1707957

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a8a4c42c4dbf
Keep dark system color extraction behind a pref for now. r=stransky

Comment 5

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/a8a4c42c4dbf