1709301 - 0.16% installer size (OSX) regression on Sat May 1 2021

Status: RESOLVED FIXED

(Firefox :: Messaging System, defect, P1)

Description

[Alexandru Ionescu (needinfo me) [:alexandrui]]

Perfherder has detected a build_metrics performance regression from push 56373c5b3a010ebf99ece851a59a27bb2c2ed481. As author of one of the patches included in that push, we need your help to address this regression.

Regressions:

Ratio	Suite	Test	Platform	Options	Absolute values (old vs new)
0.16%	installer size		osx-cross		80,200,123.00 -> 80,329,994.92

Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests. Please follow our guide to handling regression bugs and let us know your plans within 3 business days, or the offending patch(es) will be backed out in accordance with our regression policy.

For more information on performance sheriffing please see our FAQ.

Comment 1

[Release mgmt bot [:sylvestre / :calixte / :marco for bugbug]]

Set release status flags based on info from the regressing bug 1705825

Comment 2

[Emily McMinn :emcminn]

This regression was expected due to the new media (background image and shapes) included in Proton new user onboarding. We're hoping to be able to further reduce the size of the images once .avif support lands (I think 90 is the goal for that), which should fix this regression.

Comment 3

[Punam Dahiya [:pdahiya]]

One possible solution to reset the regression is by removing cfr pinned tab animation assets that are no longer used, see bug 1701091

Comment 4

[Emily McMinn :emcminn]

This should be resolved by https://bugzilla.mozilla.org/show_bug.cgi?id=1708681, which will remove CFR assets and strings.

Comment 5

[Emily McMinn :emcminn]

Bug 1708681 has closed, which should resolve this. :)