1709338 - [Proton] Warning icons are not displayed in the Download Panel

Status: VERIFIED FIXED

(Firefox :: Downloads Panel, defect)

Description

[Oana Botisan, Desktop QA]

Attachment: image (3).png

Note
*

Affected versions

• Firefox 89.0b7
• Firefox 90.0a1

Affected platforms

• Windows 10 x64
• Ubuntu 18.04 x64
• macOS 10.15

Steps to reproduce

1. Go to http://testsafebrowsing.appspot.com/s/unknown.exe.
2. Perform the download.
3. Observe the download panel.

Expected result

• The warning icon is displayed in the download list.

Actual result

• The warning icon is not displayed in the download list.

Regression range

• First bad: 29.04.2021
• Last good: 28.04.2021
• Pushlog: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=16a995d1204fa37fecf0a7ed702a62654ff4cdd0&tochange=39959393568ca6a8928bb1806eca667efa6d8b3a
• Potential regressor: Bug 1706777

Additional notes

• Please look at the attached image.
• This issue is reproduving for all types of warnings.

Comment 1

[Oana Botisan, Desktop QA]

Hi Mike! It seems that the patch from bug 1706777, caused this regression. Can you please take a look?

Comment 2

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1709338 - Make sure to show Download Panel warning icons. r?harry!

We need to supply both the width and height on the icon to make it appear. Also, as of
bug 1706777, we don't need the margin offset to vertically center the icon.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ffc96869b1e9
Make sure to show Download Panel warning icons. r=harry,desktop-theme-reviewers

Comment 4

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/ffc96869b1e9

Comment 5

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 9220133 [details]
Bug 1709338 - Make sure to show Download Panel warning icons. r?harry!

Beta/Release Uplift Approval Request

• User impact if declined: Users that download files that are marked as unsafe by the SafeBrowsing list will appear without additional warning icons in the Download Panel
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): A CSS-only patch that operates by making sure that the icons have the appropriate height and width.
• String changes made/needed: None.

Comment 6

[Romain Testard [:RT]]

Confirming here that we (UX and PM) want this uplifted for MR1 to Beta.

Comment 7

[Pascal Chevrel:pascalc]

Comment on attachment 9220133 [details]
Bug 1709338 - Make sure to show Download Panel warning icons. r?harry!

Needed for MR1, low risk approved for 89 beta 9, thanks.

Comment 8

[Pascal Chevrel:pascalc]

https://hg.mozilla.org/releases/mozilla-beta/rev/6191ebf54aa5

Comment 9

[Ciprian Georgiu, Desktop QA]

We can confirm that the issue is not reproducing anymore on latest Nightly 90.0a1, under macOS 10.15, Win 7 and Ubuntu 18.04 x64.

Comment 10

[Ciprian Georgiu, Desktop QA]

This is also verified as fixed on Beta 89.0b9 under macOS 10.15, Win 10 and Ubuntu 18.04 x64.