1709394 - Don't use chunked data to set current editable text in GeckoEditableChild.onTextChange

Status: RESOLVED FIXED

(GeckoView :: General, defect, P1)

Description

[Makoto Kato [:m_kato]]

Actually, when we set java side text from Gecko for InputConnection and GeckoEditable, we use the following binder call.

https://searchfox.org/mozilla-central/rev/185ab5e4f4e01341e009cd4633d1275ffe4d4c8b/mobile/android/geckoview/src/main/java/org/mozilla/gecko/GeckoEditableChild.java#285

    @WrapForJNI(calledFrom = "gecko", exceptionMode = "ignore")
    private void onTextChange(final CharSequence text, final int start,
                              final int unboundedOldEnd, final int unboundedNewEnd)
            throws RemoteException {
...
        mEditableParent.onTextChange(mEditableChild.asBinder(), text, start, unboundedOldEnd);

But if text is large such as 500KB, this causes binder's exception due to large data, then we cannot set valid text data to GeckoEditable. So we should use small splitted text data instead of chunked data.

Comment 1

[Makoto Kato [:m_kato]]

GeckoView beta/release channel don't crash by this exception. Nightly will crash due to diagnostics.

Comment 2

[Makoto Kato [:m_kato]]

bp-40dbb326-efec-457b-81be-2f34a0210504

Comment 3

[Makoto Kato [:m_kato]]

Attachment: Bug 1709394 - Use split text data on binder call.

When taking focus on <input> element that has large text such as 1MB, we
cannot pass current text to InputConnection.

Since we use binder call to set initial text to InputConnection, large text
causes TransactionTooLargeException exception. So we use small chunked data
(64K length) instead.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/31b84dda900f
Use split text data on binder call. r=geckoview-reviewers,agi

Comment 5

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/31b84dda900f