Open Bug 1709396 Opened 3 months ago Updated 2 months ago

[macOS] The High contrast mode will cause Dark / Light Firefox Themes to switch to Default

Categories

(Firefox :: Theme, defect, P2)

Desktop
macOS
defect

Tracking

()

Tracking Status
firefox88 --- disabled
firefox89 --- affected
firefox90 --- affected

People

(Reporter: rares.doghi, Unassigned)

References

(Depends on 1 open bug, Blocks 4 open bugs)

Details

(Whiteboard: [proton-modals] [proton-infobars] [priority:2c])

Attachments

(2 files)

[Affected platforms]:
Platforms: macOS

[Steps to reproduce]

  1. Launch the Firefox browser and set the Dark theme from about:addons
  2. Trigger any modal.
  3. Turn on High Contrast mode on macOS

[Expected result]
The Dark/Light themes should remain active

[Actual result]
The Dark/Light Themes switch back to Default

Whiteboard: [proton-infobars][proton-modals]

Is this behavior currently in Release or is this an 89 specific regression?

Flags: needinfo?(rares.doghi)
Priority: -- → P2
Whiteboard: [proton-infobars][proton-modals] → [proton-modals] [proton-infobars] [priority:2a]

Hi Tyler, no, this issue does not occur in Release, even after manually turning on the proton pref the old style modal still has the blue checked mark when High contrast is enabled. Please note that in Release the modals are different. This issue only occurs with the new Proton design.

Flags: needinfo?(rares.doghi)

Is this still happening for both modals and infobars, now that fixes in bug 1706155 and bug 1709641 have landed?

Also, can you elaborate on what you mean by "switching to default" ? Is this basically the same as bug 1709508?

Flags: needinfo?(rares.doghi)

Yes so now that those two issues have landed it seems to look a little worse, it is not switching back to default now but something else happens, and Yes I do think before it was similar to the bug 1709508 issue. Please check the new Screenshot from our latest Nightly build.

Flags: needinfo?(rares.doghi) → needinfo?(gijskruitbosch+bugs)

(In reply to Rares Doghi from comment #4)

Yes so now that those two issues have landed it seems to look a little worse, it is not switching back to default now but something else happens,

Ugh, yes, this is much worse. I filed bug 1710847 for that.

and Yes I do think before it was similar to the bug 1709508 issue.

OK. I think this bug as originally reported (before the additional issue created by bug 1709641, which also happens on Windows) was macOS-only, is that right? (per comment #0)

Flags: needinfo?(gijskruitbosch+bugs) → needinfo?(rares.doghi)
OS: Unspecified → macOS
Summary: The High contrast mode will cause Dark / Light Firefox Themes to switch to Default → [macOS] The High contrast mode will cause Dark / Light Firefox Themes to switch to Default

Yes, this was MacOS only, should we mark it as a duplicate for bug 1709508 or bug 1710847 ? I'm not sure which one will fix the underlying issue here that the theme changes to default when High contrast gets enabled on Mac.

Flags: needinfo?(rares.doghi) → needinfo?(gijskruitbosch+bugs)

(In reply to Rares Doghi from comment #7)

Yes, this was MacOS only, should we mark it as a duplicate for bug 1709508 or bug 1710847 ? I'm not sure which one will fix the underlying issue here that the theme changes to default when High contrast gets enabled on Mac.

bug 1710847 will definitely not fix this, it'll just make things readable again. I'd leave this as not-a-duplicate but depending on bug 1709508 and then we can resolve this if it does indeed get fixed by that bug.

Depends on: 1709508
Flags: needinfo?(gijskruitbosch+bugs)
Whiteboard: [proton-modals] [proton-infobars] [priority:2a] → [proton-modals] [proton-infobars] [priority:2c]
You need to log in before you can comment on or make changes to this bug.