Closed Bug 1709415 Opened 3 years ago Closed 3 years ago

Support -webkit-image-set()

Categories

(Core :: Layout: Images, Video, and HTML Frames, enhancement)

enhancement

Tracking

()

RESOLVED FIXED
90 Branch
Tracking Status
firefox90 --- fixed

People

(Reporter: jsnkuhn, Assigned: emilio)

References

Details

(Keywords: dev-doc-complete)

Attachments

(1 file)

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:88.0) Gecko/20100101 Firefox/88.0

Steps to reproduce:

existing -webkit-image-set() property values are ignored

Actual results:

Firefox skips code with the value -webkit-image-set().

Expected results:

adding support for -webkit-image-set() could retroactively cover 9 years of 2x resolution compatible web page code.

Blocks: image-set

As pointed out by Tom and Karl in bug 1107646, -webkit-image-set() is used often without the unprefixed version, so for compatibility's sake the prefixed version should be implemented.

At the same time, a warning should be logged to the console to encourage the use of the unprefixed version when only the prefixed one is used.

Sebastian

Status: UNCONFIRMED → NEW
Ever confirmed: true
Keywords: dev-doc-needed
Version: Firefox 88 → unspecified

The Bugbug bot thinks this bug should belong to the 'Core::ImageLib' component, and is moving the bug to that component. Please revert this change in case you think the bot is wrong.

Component: Untriaged → ImageLib
Product: Firefox → Core
Component: ImageLib → Layout: Images, Video, and HTML Frames
See Also: → image-set

The webkit syntax is an strict subset of the modern one, so this should
be doable, and is the simplest.

If my reading of the WebKit code is correct it should also be the way
WebKit deals with this (except they restrict -webkit-image-set() syntax
artificially).

Assignee: nobody → emilio
Status: NEW → ASSIGNED
Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/01bca848cb09
Support -webkit-image-set as a parse-time alias to image-set(). r=karlcow,twisniewski
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/28972 for changes under testing/web-platform/tests
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 90 Branch
Upstream PR merged by moz-wptsync-bot

I've added a note to the docs, added a note to BCD, and mentioned in release notes.

You need to log in before you can comment on or make changes to this bug.