Open Bug 1709420 Opened 7 months ago Updated 6 months ago

A tab-specific infobar is displayed above the browser-specific one

Categories

(Firefox :: Messaging System, defect, P3)

Desktop
All
defect

Tracking

()

Tracking Status
firefox-esr78 --- unaffected
firefox88 --- unaffected
firefox89 --- wontfix
firefox90 --- wontfix

People

(Reporter: danibodea, Unassigned)

References

(Blocks 2 open bugs, Regression)

Details

(Keywords: regression, Whiteboard: [proton-infobars])

Attachments

(1 file)

Note

  • When the user triggers the "Captive portal" info bar and then the "Protocol handler" info bar, he will notice that their display order is incorrect.

Affected versions

  • Nightly v90.0a1
  • Beta v89.0b7
  • Beta v89.0b4 (UNNAFECTED)

Affected platforms

  • all

Steps to reproduce

  1. Launch browser.
  2. Load about:config and make:
    devtools.chrome.enabled = true
  3. Open the "Browser console" (ctrl+shift+J / cmd+shift+J) and input:
    CaptivePortalWatcher._showNotification()
    Observe: browser-specific notification is displayed across all opened tabs.
  4. Load https://www.lookout.net/test/handler/
  5. Change the URL from http to https inside the second input box next to the "Run ad hoc test" button
  6. Click the "Run ad hoc test" button

Expected result

  • The tab-specific "Protocol handler" infobar is displayed below the browser-specific "Captive portal" infobar.

Actual result

  • The tab-specific "Protocol handler" infobar is displayed ABOVE the browser-specific "Captive portal" infobar, incorrectly.

Regression range

Additional notes

  • Issue logged based on the following information from Figma document:
    "All browser-specific notifications will go in one notificationbox (rather than in gHighPriorityNotificationBox and gNotificationBox). This notificationbox will be above the tab-specific notificationbox, and new notifications are added at the top of the notificationbox.
    All tab-specific notifications will be shown, with the newest notification at the bottom of the notificationbox."

The screenshot above also shows that there is a much larger gap between the first and the second toolbar than between the second and the third toolbar. Is there already a bug filed for that?

Whiteboard: [proton-infobars]
Priority: -- → P2
Whiteboard: [proton-infobars] → [proton-infobars] [priority:2a]
Blocks: 1693758

Hi Soren,

I believe the gap is intended to be bigger between the two types of infobars (browser specific/ tab specific) so they are more easily distinguishable.
Mark, could you please confirm this?

Thanks!

Flags: needinfo?(mstriemer)

The problem is that since all these bars look completely identical it's from the user's POV not obvious why there is a larger gap. It would make more sense if there would be other visual differences as well.

The gap is unintentional, the margins are just adding up in this case

Flags: needinfo?(mstriemer)

Since the bigger gap between the different types of infobars is unintentional, I've logged a separate bug for it (Bug 1710865)

See Also: → 1710865
Priority: P2 → P3
Whiteboard: [proton-infobars] [priority:2a] → [proton-infobars]
You need to log in before you can comment on or make changes to this bug.