Closed Bug 1709449 Opened 3 years ago Closed 3 years ago

[meta] Improvements to the Facebook shim script we wish to ship as part of phase 2.

Categories

(Core :: Privacy: Anti-Tracking, task, P3)

task

Tracking

()

RESOLVED FIXED
90 Branch
Tracking Status
firefox90 --- fixed

People

(Reporter: twisniewski, Assigned: twisniewski)

References

Details

(Keywords: meta)

Attachments

(1 file)

As an addendum to our phase 2 shim effort, we'd like to ensure that the federated Facebook login shim works on as many known sites as possible.

This will require us to shim Facebook's impression.php tracker, as at least the site in bug 1657828 requires it to complete the login process. But it is not a script (it is a tracking pixel), so the shim code will not be able to match it without adjustments.

Similarly, we may want to render a stand-in button on elements with the CSS class fb-login-button, for those sites which rely on the FB SDK to render it. We may wish to do this on nightly-only, so we will need the shim to be able to know which release branch it is running under. I'd also like to begin testing opt-in placeholders for FB videos on the nightly cycle, so this fits.

In addition, there are several minor changes that will also help:

  • allowlisting these URLs, which are required to complete the login on some sites, show profile images, etc:
    *://graph.facebook.com/v*/*
    *://graph.facebook.com/*/picture*
    *://www.facebook.com/*/plugins/login_button.php*
    *://www.facebook.com/x/oauth/status*
  • shimming window.FB.ui for sites which use it instead of window.FB.login.
  • shimming window.FB.Event.(un)subscribe for sites which listen for login events.

Finally, there is an improvement we can make to the shim engine for opt-ins, which ensures that requests for opt-in content are allowed only on the tabs on which the user has opted in.

Summary: Improvements to the Facebook shim script we wish to ship as part of phase 2. → [meta] Improvements to the Facebook shim script we wish to ship as part of phase 2.
Depends on: 1710622
Pushed by twisniewski@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8cb449906c81
Changes to the Facebook SmartBlock shim to bring it in line with phase 2 SmartBlock expectations, including relevant SmartBlock engine changes; r=denschub,webcompat-reviewers
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 90 Branch
Regressions: 1712562
Blocks: 1710622
No longer depends on: 1710622
See Also: → 1226498
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: