1709452 - Do not store display list building rect in frames with continuations

Status: RESOLVED FIXED

(Core :: Web Painting, defect, P2)

Description

[Miko Mynttinen]

In bug 1707170 we uncovered an issue where retained display lists trip with frame continuations. If a modified frame is in the child list of the earlier unmodified continuation frame of the split frame, we cannot store display list building rect there, because we might not descend into that subframe tree.

Comment 1

[Miko Mynttinen]

Attachment: Bug 1709452 - Do not store display list building rect in frames with continuations r=mattwoodrow

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/131f7f15056f
Do not store display list building rect in frames with continuations r=mattwoodrow

Comment 3

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/131f7f15056f

Comment 4

[Miko Mynttinen]

Comment on attachment 9220227 [details]
Bug 1709452 - Do not store display list building rect in frames with continuations r=mattwoodrow

Beta/Release Uplift Approval Request

• User impact if declined: Possible invalidation issues: style changes might not update correctly.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): The patch is simple: it only adds an additional limitation where display list rebuild rectangles can be stored. This trades some performance for correctness.
• String changes made/needed:

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9220227 [details]
Bug 1709452 - Do not store display list building rect in frames with continuations r=mattwoodrow

Approved for 89.0b14.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/38571c2f67f8