1709474 - additional selectAudioOutput() boilerplate

Status: RESOLVED FIXED

(Core :: WebRTC: Audio/Video, enhancement, P1)

Description

[Karl Tomlinson (:karlt)]

+++ This bug was initially created as a clone of Bug #1698238 +++

Following on from bug 1698238, more C++ code to provide selectAudioOutput() API and dispatch requests to and receive responses from observers that will need to handle permission and prompts. The observers and the effects on emunerateDevices() and setSinkId() results are still not included.

Comment 1

[Karl Tomlinson (:karlt)]

Attachment: rename nsIDOMNavigatorUserMedia.idl to nsIMediaDevice.idl

This is more appropriate since
https://hg.mozilla.org/mozilla-central/rev/db29f053e54ef83da3e313de6e85f3b850faa543#l5.12
and helps generated webidl bindings find the right header.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/65c1a0390814
rename nsIDOMNavigatorUserMedia.idl to nsIMediaDevice.idl r=jib

Comment 3

[Karl Tomlinson (:karlt)]

Attachment: Bug 1709474 move mozGetUserMediaDevices from Navigator to GetUserMediaRequest

Comment 4

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/65c1a0390814

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/069415280f6d
move mozGetUserMediaDevices from Navigator to GetUserMediaRequest r=jib,webidl,geckoview-reviewers,smaug,agi

Comment 6

[Karl Tomlinson (:karlt)]

Attachment: Bug 1709474 Test effect of selectAudioOutput() on audiooutput devices from enumerateDevices()

Comment 7

[Karl Tomlinson (:karlt)]

Attachment: Bug 1709474 add a helper method for bypassing permission prompt

Comment 8

[Karl Tomlinson (:karlt)]

Attachment: Bug 1709474 send selectAudioOutput requests to app

Comment 9

[Natalia Csoregi [:nataliaCs]]

Backed out for geckoview fails on testDeviceRecordingEventAudioAndVideo along with Bug 1709484

backout: https://hg.mozilla.org/integration/autoland/rev/ee547d7fb4ecdd0a9084ac80a7fbeb408e527946

push: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&revision=069415280f6d2a906370892d16a3a9d3b6f1e8fd&searchStr=android&selectedTaskRun=AafBDx-dSU-Jg97NbCkDJQ.0

failure log:

• TEST-UNEXPECTED-FAIL | org.mozilla.geckoview.test.MediaDelegateTest.testDeviceRecordingEventAudioAndVideo | org.mozilla.geckoview.test.util.UiThreadUtils$TimeoutException: Timed out after 30000ms
• TEST-UNEXPECTED-FAIL | org.mozilla.geckoview.test.MediaDelegateTest.testDeviceRecordingEventVideo | org.mozilla.geckoview.test.util.UiThreadUtils$TimeoutException: Timed out after 30000ms

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f7bdd9980783
move mozGetUserMediaDevices from Navigator to GetUserMediaRequest r=jib,webidl,geckoview-reviewers,smaug,agi

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e630f18812ad
add a helper method for bypassing permission prompt r=jib
https://hg.mozilla.org/integration/autoland/rev/7ecfcfcd2ffe
send selectAudioOutput requests to app r=jib
https://hg.mozilla.org/integration/autoland/rev/1f2b98830e0b
Test effect of selectAudioOutput() on audiooutput devices from enumerateDevices() r=jib

Comment 12

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/28860 for changes under testing/web-platform/tests

Comment 13

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/f7bdd9980783
https://hg.mozilla.org/mozilla-central/rev/e630f18812ad
https://hg.mozilla.org/mozilla-central/rev/7ecfcfcd2ffe
https://hg.mozilla.org/mozilla-central/rev/1f2b98830e0b

Comment 14

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot