Switch to using Services.io in chatZilla
Categories
(SeaMonkey :: Chat, task)
Tracking
(seamonkey2.53+ fixed)
People
(Reporter: iannbugzilla, Assigned: iannbugzilla)
Details
(Whiteboard: SM2.53.9)
Attachments
(1 file, 2 obsolete files)
17.05 KB,
patch
|
iannbugzilla
:
review+
iannbugzilla
:
approval-comm-release+
iannbugzilla
:
approval-comm-esr60+
|
Details | Diff | Splinter Review |
Rather than storing io service in client.iosvc or similar just make use of Services.io
At the same time remove old code around use of URLSpec and port:
- Bug 1329958 - remove trailing newURI null parameters in comm-central
[Approval Request Comment]
Regression caused by (bug #): n/a
User impact if declined: none
Testing completed (on m-c, etc.): 2.53.8
Risk to taking this patch (and alternatives if risky): low
String changes made by this patch: none
Removed a now unused const
Comment 3•3 years ago
|
||
Comment on attachment 9220954 [details] [diff] [review]
1709579-irc-iosvc-2539.patch
suite/extensions/irc/js/lib/connection-xpcom.js
suite/extensions/irc/js/lib/utils.js
suite/extensions/irc/xul/content/commands.js
suite/extensions/irc/xul/content/handlers.js
suite/extensions/irc/xul/content/nsDragAndDrop.js
NIT: Does not import Services but seems to pick it up from another file.
suite/extensions/irc/xul/content/commands.js
This probably works but SEC_NORMAL looks risky and is gone from later releases:
-
var channel = Services.io.newChannel2(
-
e.url, "UTF-8", null, null,
-
Services.scriptSecurityManager.getSystemPrincipal(),
-
null, Ci.nsILoadInfo.SEC_NORMAL,
-
Ci.nsIContentPolicy.TYPE_OTHER);
Would probably use Services.io.newChannelFromURI( otherwise needs to be fixed up for 2.57 and up because newChannel2 is gone. But would need a uri not an url.
Either way try Ci.nsILoadInfo.SEC_ALLOW_CROSS_ORIGIN_DATA_IS_NULL instead of SEC_NORMAL.
r/a+ with issues fixed or discussed if not.
Changed to Ci.nsILoadInfo.SEC_ALLOW_CROSS_ORIGIN_SEC_CONTEXT_IS_NULL
newChannel2 doesn't go away until 67 so okay to use in 2.53.x
Carrying forward r/a
Pushed by frgrahl@gmx.net:
https://hg.mozilla.org/comm-central/rev/6de6dca432a6
Switch to using Services.io in chatZilla. r=frg
Updated•3 years ago
|
Comment 6•3 years ago
|
||
https://gitlab.com/seamonkey-project/seamonkey-2.53-comm/-/commit/d1051a3750472ad51d34384d2283bffbfb470c92
Switch to using Services.io in chatZilla. r=frg a=frg
Description
•