170959 - composer window is raised after publishing completes

Status: VERIFIED FIXED

(SeaMonkey :: Composer, defect)

Description

[Mark Smith [:mcs]]

Running with Netscape 7.0 on Windows 2000sp3 (tried to reproduce with Mozilla
1.1 and 1.2a but the publishing progress dialog does not automatically close on
those builds - already filed as bug 167996).

Problem: even if you switch to another Mozilla window (e.g., a browser window)
while the publishing progress dialog is open, the composer window associated
with the publishing progress dialog is raised and made the top-most window after
publishing completes. This is annoying and disruptive.

Steps to reproduce:

1) Open a browser window and a composer window (can be for the same page).

2) Click on the Publish toolbar icon, type password if necessary.

3) While the progress dialog says "Publishing..." switch to the browser window.

4) Wait for publishing to complete and the progress dialog to close by itself.
Notice that the composer window is raised to the top and the browser window is
lowered.

Comment 1

[Mark Smith [:mcs]]

This can't be fixed until after bug 167996 is fixed.

Comment 2

[Mark Smith [:mcs]]

The same thing happens with Mozilla 1.0.1 on Windows 2000.

Comment 3

[Charles Manske]

This is unavoidable. The publishing progress dialog is a non-modal child window
of the Composer window. There is intricate interaction between the two to
post messages to the progress dialog. When it closes, you are now editing the 
document at a new location, so showing that to the user and putting focus back
to the Composer page makes sense for most users. This is what causes the 
Composer window to come forward.
Brade: Is this wontfix?

Comment 4

[Mark Smith [:mcs]]

Hmmm. My suggestion is that if the progress dialog does not have focus at the
time it closes itself, then focus should NOT be returned to the associated
composer window. Does that make sense?

Comment 5

[Kathleen :Brade]

confirming; I suggested comment 4

Comment 6

[Charles Manske]

Sounds good to me! I'll try to do that.

Comment 7

[Charles Manske]

Attachment: patch v1

In "SetDocumentEditable(true)", which is called when we are done publishing,
we were explicitly setting focus to the Composer window. The reason was because

that used to be necessary for "window.updateCommands()" to work, but I tried 
simply removing that line and the commands seem to update perfectly fine!

Comment 8

[Kathleen :Brade]

Comment on attachment 100784 [details] [diff] [review]
patch v1

r=brade

Can we add a comment somewhere indicating that we shouldn't call focus due to
bug 170959?  I'm not sure exactly where the comment should go but I'm sure you
can find the best place for it.

Comment 9

[Alec Flett]

Comment on attachment 100784 [details] [diff] [review]
patch v1

sr=alecf

Comment 10

[Charles Manske]

checked into 1.2beta trunk

Comment 11

[sujay]

Mark, can you please verify if this is fixed for you in latest build ?

thanks.

Comment 12

[Mark Smith [:mcs]]

Verified on Windows in a trunk build from 2002-10-08.

Comment 13

[Kathleen :Brade]

*** Bug 143429 has been marked as a duplicate of this bug. ***