Closed Bug 1709591 Opened 5 months ago Closed 4 months ago

[RTL] The FxA "Show More Tabs" arrow points upwards instead of downwards

Categories

(Firefox :: Menus, defect, P2)

defect

Tracking

()

VERIFIED FIXED
90 Branch
Tracking Status
firefox88 --- wontfix
firefox89 --- wontfix
firefox90 --- verified

People

(Reporter: alin.ilea, Assigned: mconley)

References

(Blocks 2 open bugs)

Details

(Whiteboard: [proton-hamburger-menu] [priority:2b])

Attachments

(2 files)

Tested with:

Release 88
Beta 89.0b8
Nightly 90.0a1 (2021-05-04)

Tested on:

Windows 10
Windows 7

Preconditions:

RTL build installed.

Steps:

  1. Launch firefox (RTL build) and sign in into FxA using 2 devices.
  2. Open more than 25 tabs on one device and sync tabs with another devices.
  3. Open the hamburger menu, go to Firefox Account submenu and scroll down to the "Show More Tabs" option .

Actual result:

The "Show More Tabs" arrow points upwards instead of downwards.

Expected result:

The "Show More Tabs" arrow should points downwards in order to expand the list of synced devices.

Ni? @Tyler for prioritize this.

Flags: needinfo?(tduzan)
Flags: needinfo?(tduzan)
Priority: -- → P2
Whiteboard: [proton-hamburger-menu] → [proton-hamburger-menu] [priority:2b]
Assignee: nobody → mconley

Before this patch, we were showing a downward-pointing expander icon by taking a
rightward-pointing one and rotating it 90deg. That's fine, except for RTL, where we
tend to mirror rightward-pointing arrows with a scale: -1 1; rule. Because of
order of operations, the scale rule is applied first, and the 90deg rotation
that occurs afterwards ends up pointing the scaled arrow upwards.

Instead of special-casing the scale rule for this expander icon, I've gone ahead
and switched it to use arrow-dropdown-16.svg and gotten rid of the rotation. This
way, even if we mirror across the y-axis with scale: -1 1, the appearance will
not change.

Pushed by mconley@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e69e2aecb3dc
Use arrow-dropdown-16.svg for the Synced Tabs expander icon rather than rotating a right-pointing one. r=mhowell
Status: NEW → ASSIGNED
Status: ASSIGNED → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → 90 Branch

Verified - Fixed in latest Nightly 90.0a1 (build id: 20210519214756) using Windows 10 and Ubuntu 20. The "Show More Tabs" arrow points accordingly, downwards, in RTL builds.

Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.