double tap zoom on lists inside wikipedia sidebars tables zoom too far
Categories
(Core :: Panning and Zooming, defect)
Tracking
()
People
(Reporter: tnikkel, Assigned: tnikkel)
References
Details
Attachments
(1 file)
48 bytes,
text/x-phabricator-request
|
pascalc
:
approval-mozilla-beta+
|
Details | Review |
Load https://en.wikipedia.org/wiki/United_States
In the sidebar on the right, double tap one of the percentages in the Ethnic groups box. Ideally we'd zoom to the side bar width, but we zoom to smaller than that.
From bug 1699147, comment 27.
Assignee | ||
Comment 1•3 years ago
|
||
Updated•3 years ago
|
Pushed by tnikkel@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/c3cafff6f652 Allow the double tap heuristic to look at grand parent for table cells. r=emilio
Comment 3•3 years ago
|
||
bugherder |
Assignee | ||
Comment 4•3 years ago
|
||
Comment on attachment 9220377 [details]
Bug 1709614. Allow the double tap heuristic to look at grand parent for table cells. r?emilio
Beta/Release Uplift Approval Request
- User impact if declined: double tap zoom on wikipedia sidebars and other similar things zooms in too far sometimes
- Is this code covered by automated tests?: Yes
- Has the fix been verified in Nightly?: No
- Needs manual test from QE?: No
- If yes, steps to reproduce:
- List of other uplifts needed: None
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): very slight change to double tap heuristic, affects no other code/functionality.
- String changes made/needed:
Comment 5•3 years ago
|
||
Comment on attachment 9220377 [details]
Bug 1709614. Allow the double tap heuristic to look at grand parent for table cells. r?emilio
Small patch with tests and we are in early betas, approved for 89 beta 9, thanks.
Comment 6•3 years ago
|
||
bugherder uplift |
Comment 7•3 years ago
|
||
This is verified fixed using Firefox 89.0b9 (BuildId:20210506185706) and Firefox 90.0a1 (BuildID:20210506214311) on macOS 10.14.
Double tap to zoom now zooms accordingly to the tables width.
Updated•3 years ago
|
Description
•