Closed Bug 1709625 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 28839 - Don't miss list item markers inside multicol containers.

Categories

(Core :: Layout: Columns, task, P4)

Product:
Core
Component:
Layout: Columns
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
90 Branch
Tracking Flags:
Tracking Status
firefox90 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 28839 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/28839
Details from upstream follow.

b'Morten Stenshorne <mstensho@chromium.org>' wrote:

Don't miss list item markers inside multicol containers.

With list-style-position:inside, we'd fail to find the marker if it was
inside a multicol container, because we'd look for it in the flow
thread, and give up, since the flow thread isn't the list-item (the
multicol container (the parent LayoutObject) is).

Flow threads should be ignored in LayoutNG. Use
GetLayoutObjectForParentNode() if we need to walk up the tree, to get
this right. Templatize GetLayoutObjectForParentNode(), so that it can
provide both a const and non-const version. CollectInlinesInternal()
works on non-const objects, and there doesn't seem to be an easy way
around that.

This fixes the final failures in multicol-span-all-list-item-001.html
and multicol-span-all-list-item-002.html, but since those tests were
quite complicated (and mostly about spanners, even if this CL has
nothing to do with spanners), I added a simpler test for this specific
issue.

Bug: 829028, 1130451
Change-Id: I6bcf10593a68c40cbc9adc11f9572c9aee580623

Reviewed-on: https://chromium-review.googlesource.com/2874650
WPT-Export-Revision: f5c837c3a5c3ccb54a74944e52a12c86152b768a

Component: web-platform-tests → Layout: Columns
Product: Testing → Core
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]

CI Results

Ran 15 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests

Status Summary

Firefox

PASS: 1

Chrome

PASS: 1

Safari

PASS: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8e98bcb9cd01
[wpt PR 28839] - Don't miss list item markers inside multicol containers., a=testonly

https://hg.mozilla.org/mozilla-central/rev/8e98bcb9cd01

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox90: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 90 Branch
You need to log in before you can comment on or make changes to this bug.