1709654 - Update for NetBSD configuration

Status: RESOLVED FIXED

(NSS :: Build, enhancement, P5)

Description

[Thomas Klausner]

Attachment: patch-nss_coreconf_NetBSD.mk

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:88.0) Gecko/20100101 Firefox/88.0

Steps to reproduce:

In the NetBSD configuration, the symbol hiding flags are not defined. This leads to conflicts when openssl and nss are linked into the same binary.
For a longer discussion on the topic, see
https://groups.google.com/a/mozilla.org/g/dev-tech-crypto/c/Al0Pt0zhARE

Actual results:

The nss symbols are not hidden.

Expected results:

The nss symbols should be hidden.
I'll attach a patch to fix this, making the config more similar to the OpenBSD one.
The patch also fixes the configuration for arm and arm64, and removes support for a.out, which has not been supported in NetBSD for over 10 years now.

Comment 1

[Robert Relyea]

Thomas, can you attach the file as a patch (probably the easiest way is to make it have the extention .patch). Then Bugzilla will create approval flags which I can turn on.
thanks,
bob

Comment 2

[Thomas Klausner]

Attachment: patch-nss_coreconf_NetBSD.mk.patch

Same patch, different extension and file type.

Comment 3

[Robert Relyea]

Comment on attachment 9221412 [details] [diff] [review]
patch-nss_coreconf_NetBSD.mk.patch

Review of attachment 9221412 [details] [diff] [review]:
-----------------------------------------------------------------

These changes are all reasonable, and are submitted by the NETBSD upstream maintainer. The changes are isolated in the NETBSD only header file.

Comment 4

[Robert Relyea]

Checked in:
https://hg.mozilla.org/projects/nss/rev/a7769615f2853999db7ff14278829e2eb513a108

Comment 5

[Mathew Hodson]

Can this bug be closed?

Comment 6

[Thomas Klausner]

Yes, thank you!