1709678 - Browsing chat logs clears the topic

Status: RESOLVED FIXED

(Thunderbird :: Instant Messaging, defect)

Description

[Martin Giger [:freaktechnik]]

STR:

• View a conversation with logs and a topic
• Select some logs to view
• Exit the log viewer

Expected result:
The topic stays displayed below the conversation name.

Actual result:
The topic is cleared when viewing the log and not restored when closing the viewer. Previous behavior didn't even clear the topic in the first place.

Based on mozregression I think the regression is from https://hg.mozilla.org/comm-central/rev/9c30d915b033eac597a413f39840285c5b889661

Comment 1

[Henry Wilkes (they/them) [:henry-x]]

Are these just the group "chat" logs, or does it also include the one-to-one logs?

If its only the former then this is probably from this change https://hg.mozilla.org/comm-central/rev/9c30d915b033eac597a413f39840285c5b889661#l17.15

I set the topic to "" because I thought it was archived content, so the current topic text didn't make sense. If you want to keep the topic in view, then you probably want to use a similar approach as in updateTopic https://searchfox.org/comm-central/rev/343b0f067aa13526b37b3254f614d1bfe9feeba2/mail/components/im/content/chat-conversation.js#1548

And, to restored the topic on closing the logs, you should be able to just call the updateTopic method, or updateConvStatus (which will call updateTopic and will also set the display name).

--

Also, when looking through the code I noticed that initConversationUI calls updateTopic, even though it will always call updateConvStatus, which already calls updateTopic. So the updateTopic call in initConversationUI can be dropped.

Comment 2

[Martin Giger [:freaktechnik]]

The status is not cleared for direct message logs, yes. It is only the topic of MUCs that gets cleared and at least not re-set when closing the log.

Comment 3

[Martin Giger [:freaktechnik]]

Attachment: Bug 1709678 - Restore topic when leaving log view. r=clokep

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/c78ba6ab31ca
Restore topic when leaving log view. r=clokep

Comment 5

[Magnus Melin [:mkmelin]]

Looks like it's breaking at least comm/mail/components/im/test/browser/browser_logs.js

Comment 6

[Martin Giger [:freaktechnik]]

Given it added that test that seems unfortunate... I'll have a look.

Comment 7

[Martin Giger [:freaktechnik]]

Attachment: Bug 1709678 - Follow-up: fix browser_logs test. r=clokep

Also uses shared helpers in browser_contextMenu

Comment 8

[Martin Giger [:freaktechnik]]

Not sure if I also need to change the status of the bug for the checkin needed to be processed?

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/6f31a82fb9d8
Follow-up: fix browser_logs test. r=clokep