[wpt-sync] Sync PR 28848 - Simplify code converting os.environ to strings (avoiding six)
Categories
(Testing :: web-platform-tests, task, P4)
Tracking
(firefox90 fixed)
| Tracking | Status | |
|---|---|---|
| firefox90 | --- | fixed |
People
(Reporter: mozilla.org, Unassigned)
References
()
Details
(Whiteboard: [wptsync downstream])
Sync web-platform-tests PR 28848 into mozilla-central (this bug is closed when the sync is complete).
PR: https://github.com/web-platform-tests/wpt/pull/28848
Details from upstream follow.
b'Philip J\xc3\xa4genstedt <philip@foolip.org>' wrote:
Simplify code converting os.environ to strings (avoiding six)
os.environ always uses str on Python 3, there's a new os.environb for a
bytes version, which isn't supported on Windows:
https://docs.python.org/3/library/os.html#os.environ
https://docs.python.org/3/library/os.html#os.environbSimply trust os.environ to be a dict[str, str], and simplify the
openssl.py code to something more like in GeckoDriverServer and
elsewhere:
https://github.com/web-platform-tests/wpt/blob/302039ac7c43c71bc5389104c81871b81d6cc9e0/tools/wptrunner/wptrunner/webdriver_server.py#L187-L193Part of https://github.com/web-platform-tests/wpt/issues/28776.
|
Assignee | |
Comment 1•3 years ago
|
||
PR 28848 applied with additional changes from upstream: 305a8f93d252c4451f3dbbf76402187906fa0298
|
|
Assignee | |
Comment 2•3 years ago
|
||
Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=f418e446309f5a170bd783f7d32bb3090f6848ea
|
|
Assignee | |
Comment 3•3 years ago
|
||
The PR was not expected to affect any tests, but the try push wasn't a success. Check the try results for infrastructure issues
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/5f2d82562608 [wpt PR 28848] - Simplify code converting os.environ to strings (avoiding six), a=testonly
|
|
Assignee | |
Comment 5•3 years ago
|
||
Test result changes from PR not available.
|
||
Comment 6•3 years ago
|
||
| bugherder | ||
Description
•