1709784 - 0.39% installer size (OSX) regression on Thu May 6 2021

Status: RESOLVED WONTFIX

(Core :: Graphics: ImageLib, defect)

Description

[Alexandru Ionescu (needinfo me) [:alexandrui]]

Perfherder has detected a build_metrics performance regression from push 3bd32289312743cdae84f8a0741b158142d3e262. As author of one of the patches included in that push, we need your help to address this regression.

Regressions:

Ratio	Suite	Test	Platform	Options	Absolute values (old vs new)
0.39%	installer size		osx-cross		80,360,650.33 -> 80,672,819.75

Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests. Please follow our guide to handling regression bugs and let us know your plans within 3 business days, or the offending patch(es) will be backed out in accordance with our regression policy.

For more information on performance sheriffing please see our FAQ.

Comment 1

[Kagami Rosylight [:saschanaz] (they/them)]

I'd say this is expected as we just added a whole new library. 310 KiB is 10 times smaller than the static library size (3,414 KiB for jxl_dec-static.lib on Windows) and thus is within the expected range.

Comment 2

[Kagami Rosylight [:saschanaz] (they/them)]

Do you think comment #1 is a valid reason? To follow the words from the build metrics regression doc, the patches are required to add JXL support and there is no good alternative.

Comment 3

[Alexandru Ionescu (needinfo me) [:alexandrui]]

I understand. I am fine with cosing this as WONTFIX.

Comment 4

[Kagami Rosylight [:saschanaz] (they/them)]

Cool, please let me do that right now: