1709792 - Har automation breaks on target switching

Status: RESOLVED FIXED

(DevTools :: Netmonitor, enhancement)

Description

[Alexandre Poirot [:ochameau]]

Har automation:

1. store the first top level target web console front and use it for the whole lifecycle of the toolbox. It starts breaking on the first top level target switch as the first console front is destroyed.
2. only listen to will-navigate and navigate, so never picks up the new top level target
3. navigate is broken with JSWindowActor based targets (bug 1632141)

We should make this codebase rely on DOCUMENT_EVENT's dom-complete and avoid memoizing the console front (or use onTargetAvailable to update it).

Comment 1

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1709792 - [devtools] Support target switching in har automation.

• Stop memoizing web console front
• track navigate via DOCUMENT_EVENT's dom-complete
• workaround missed early will-navigate

These changes help fix browser_harautomation_simple.js

Comment 2

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1709792 - [devtools] Pass around commands in har automation.

Make this codebase fully embrace commands and stop being target/toolbox oriented.

Comment 3

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1709792 - [devtools] Remove har's toolbox overlay.

This introduces uncessary complexity and makes it uterly complex to wait
for HarAutomation's async initialization.
Its init isn't async yet.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e955296ccb07
[devtools] Pass around commands in har automation. r=bomsy
https://hg.mozilla.org/integration/autoland/rev/74967859ddaf
[devtools] Remove har's toolbox overlay. r=bomsy
https://hg.mozilla.org/integration/autoland/rev/fac4711a3e2e
[devtools] Support target switching in har automation. r=bomsy

Comment 5

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/e955296ccb07
https://hg.mozilla.org/mozilla-central/rev/74967859ddaf
https://hg.mozilla.org/mozilla-central/rev/fac4711a3e2e