Enable asm.js on ARM64
Categories
(Core :: JavaScript: WebAssembly, enhancement, P2)
Tracking
()
Tracking | Status | |
---|---|---|
firefox90 | --- | fixed |
People
(Reporter: lth, Assigned: lth)
References
Details
Attachments
(1 file)
Asm.JS is disabled on ARM64 in AsmJS.cpp:
static bool IsAsmJSCompilerAvailable(JSContext* cx) {
#ifdef JS_CODEGEN_ARM64
// Disable asm.js-via-Ion on arm64 until such time as that pathway, along
// with the associated compiler-option logic, is better tested. asm.js will
// still be available on arm64, but will be forced along the JS pathway,
// with the associated performance lossage. See bugs 1699379 and 1697560.
return false;
#endif
return HasPlatformSupport(cx) && IonAvailable(cx);
}
Now that we have Ion on ARM64, we should try to reenable this. It may be that we should consider leaving it off for Cranelift; need to investigate this.
Assignee | ||
Comment 1•4 years ago
|
||
This simply removes the arm64 ifdef in IsAsmJSCompilerAvailable that would cause the
asm.js compiler to be unavailable on that platform.
The decision is thus delegated to WasmCompilerForAsmJSAvailable(cx), and that
predicate amounts to IonAvailable(cx), since the status of Cranelift for asm.js
is that it's not supported yet. When we have a chance to test Cranelift we
can enable asm.js support.
Depends on D114479
Comment 3•4 years ago
|
||
Backed out 2 changesets (bug 1697560, bug 1709803) for Spidermonkey failures in Debugger-allowUnobservedAsmJS-02.js. CLOSED TREE
Log:
https://treeherder.mozilla.org/logviewer?job_id=339074581&repo=autoland&lineNumber=17100
Push with failures:
https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&revision=15c327320950ae6a44cb9607a5848cf48d6ce65f
Backout:
https://hg.mozilla.org/integration/autoland/rev/d148a17a6711a31cbebd725fd2e7c02039ce7ef9
Assignee | ||
Updated•4 years ago
|
Comment 5•4 years ago
|
||
bugherder |
Description
•