1709848 - Crash in [@ shutdownhang | nsNSSComponent::ShutdownNSS]

Status: RESOLVED FIXED

(Core :: Security: PSM, defect)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

This signature existed before but since ~2021-04-14, crashes are being observed more frequently on Nightly (64 crashes on Nightly in the last monght, 89 betas are unaffected).

Crash report: https://crash-stats.mozilla.org/report/index/fab8dc3e-26bf-4645-bf26-87ec50210414

MOZ_CRASH Reason: Shutdown hanging at step profile-before-change. Something is blocking the main-thread.

Top 10 frames of crashing thread:

0 ntdll.dll NtWaitForAlertByThreadId 
1 ntdll.dll RtlSleepConditionVariableSRW 
2 kernelbase.dll SleepConditionVariableSRW 
3 mozglue.dll mozilla::detail::ConditionVariableImpl::wait mozglue/misc/ConditionVariable_windows.cpp:50
4 xul.dll nsNSSComponent::ShutdownNSS security/manager/ssl/nsNSSComponent.cpp:1990
5 xul.dll nsNSSComponent::Observe security/manager/ssl/nsNSSComponent.cpp:2271
6 xul.dll nsObserverList::NotifyObservers xpcom/ds/nsObserverList.cpp:70
7 xul.dll nsObserverService::NotifyObservers xpcom/ds/nsObserverService.cpp:288
8 xul.dll mozilla::AdvanceShutdownPhaseInternal xpcom/base/AppShutdown.cpp:330
9 xul.dll nsXREDirProvider::DoShutdown toolkit/xre/nsXREDirProvider.cpp:1040

Comment 1

[Dana Keeler (she/her) [:keeler]]

Attachment: Bug 1709848 - osclientcerts: don't scan for certificates when loaded r?bbeurdouche

Before this patch, osclientcerts would look for client certificates and keys
upon initialization. However, this is unnecessary, given that most users won't
ever even be asked to use them. This patch avoids doing this work at startup,
saving some time there. Additionally, this should help avoid shutdown hangs
related to the background task that loads osclientcerts.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a9adf8c21943
osclientcerts: don't scan for certificates when loaded r=bbeurdouche

Comment 3

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/a9adf8c21943

Comment 4

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Dana: Should the remaining reports get a new bug or this one be reopened?

Comment 5

[Dana Keeler (she/her) [:keeler]]

A new bug would be great, thanks.