1709864 - Prevent nsWindow::OnPaint() flooding on Windows

Status: RESOLVED DUPLICATE of bug 1710533

(Core :: Widget: Win32, enhancement)

Description

[Sotaro Ikeda [:sotaro]]

Crated from Bug 1701451 comment 20.

nsWindow::Resize() does not update window size when size was negative like (447.0, -912.0). It caused a lot of nsWindow::OnPaint() calls as in Bug 1701451 comment 19.

Comment 1

[Sotaro Ikeda [:sotaro]]

Attachment: Bug 1709864 - Fix nsWindow::Resize() on Windows

Comment 2

[Jim Mathies [:jimm]]

I or Miko can review this.

Comment 3

[Sotaro Ikeda [:sotaro]]

Close this bug by preferring Bug 1709998.

Comment 4

[Sotaro Ikeda [:sotaro]]

(In reply to Sotaro Ikeda [:sotaro] from comment #3)

Close this bug by preferring Bug 1709998.

I changed my mind. It seems better to add handling for avoiding onPaint() flood. Bug 1709998 prevent to trigger onPaint() flooding. But if onPaint() flooding happens, it still could cause the hang.

Comment 5

[Sotaro Ikeda [:sotaro]]

On nsWindow::OnPaint() triggers, next OnPaint via nsWindow::Invalidate(). nsWindow::Invalidate() was called in nsWindow::Resize() when requested height was negative.

widget->ResizeClient() was always called in nsView::DoResetWidgetBounds(), since nsWindow::Resize() did not update widget size.

ConstrainSize(&width, &height) prevented to update widget size.

Comment 6

[Sotaro Ikeda [:sotaro]]

Error situation could be checked by gfxCriticalNoteOnce by Bug 1710335.