Closed Bug 1709971 Opened 3 years ago Closed 3 years ago

Entering text in the urlbar ending with a carriage return (0D), line feed (0A), or both selects search shortcut in first position of Top Sites list

Categories

(Firefox :: Address Bar, defect, P3)

Firefox 88
defect
Points:
3

Tracking

()

VERIFIED FIXED
90 Branch
Tracking Status
firefox-esr78 --- unaffected
firefox88 --- wontfix
firefox89 --- wontfix
firefox90 --- verified

People

(Reporter: jscher2000, Assigned: daisuke)

References

(Regression)

Details

(Keywords: regression)

Attachments

(1 file)

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:88.0) Gecko/20100101 Firefox/88.0

Steps to reproduce:

Select and copy a cell in Excel or text in a text document including the subsequent line break, paste to the address bar, and press Enter.

Actual results:

If a pinned search shortcut is in the first position of the Top Sites list and the user is displaying Top Sites in the address bar autocomplete drop-down -- this is the default configuration -- instead of handling the address or query string normally, Firefox behaves as though the user clicked the first Top Site, shows the relevant search engine name at the left end of the address bar, and discards the pasted input.

(As reported in: https://support.mozilla.org/questions/1335231 and https://www.reddit.com/r/firefox/comments/n5tait/annoying_blue_amazon_search_box_when_opening_a/ )

Expected results:

Firefox should disregard the 0D 0A on URL bar input.

Component: Untriaged → Address Bar

Mozregression points to bug 1185358 as the patch behind this change.

Regressed by: 1185358
Has Regression Range: --- → yes

Thanks for debugging this, jscher. It looks like the urlbar view must be opened at least once before pasting and pressing enter, and the pasted string must end in a CR, LF, or CR+LF. Here are the STR that work for me:

  1. Open a new tab
  2. Click the urlbar or press accel+L open the view with your top sites
  3. Paste a string that ends in a line feed (0A), carriage return (0D), or CR+LF (0D0A)
  4. Observe that the view does not open like it should
  5. Press enter
  6. Observe that Firefox behaves as if the first result in the view was picked (I'm guessing -- my first result is the Amazon shortcut/keyword offer, and it gets picked)
Severity: -- → S3
Status: UNCONFIRMED → NEW
Points: --- → 3
Ever confirmed: true
Priority: -- → P3

Daisuke, do you have any time to look into this? No problem if not, I probably will if you don't.

Flags: needinfo?(daisuke)
Summary: Submitting text ending with 0D 0A in the URL bar selects search shortcut in first position of Top Sites list → Entering text in the urlbar ending with a carriage return (0D), line feed (0A), or both selects search shortcut in first position of Top Sites list

Sure! I will take this issue.

Assignee: nobody → daisuke
Status: NEW → ASSIGNED
Flags: needinfo?(daisuke)
Pushed by dakatsuka.birchill@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/84eab701c0e6
Request autocomplete upon pasting value. r=adw
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 90 Branch

The patch landed in nightly and beta is affected.
:daisuke, is this bug important enough to require an uplift?
If not please set status_beta to wontfix.

For more information, please visit auto_nag documentation.

Flags: needinfo?(daisuke)

Comment on attachment 9221468 [details]
Bug 1709971: Request autocomplete upon pasting value.

Beta/Release Uplift Approval Request

  • User impact if declined: Even if user pastes ipaddress/url that ends with \r by middle clicking, then type enter, it can not go to the page.
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: No
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): The main changes are only 6 lines, and it affects only pasting by middle clicking.
  • String changes made/needed: none
Flags: needinfo?(daisuke)
Attachment #9221468 - Flags: approval-mozilla-beta?

Comment on attachment 9221468 [details]
Bug 1709971: Request autocomplete upon pasting value.

We shipped 87 and 88 with this bug, it recently landed on nightly and we are nearing the beta cycle, I think it should ride the 90 train, thanks.

Attachment #9221468 - Flags: approval-mozilla-beta? → approval-mozilla-beta-
Flags: qe-verify+
QA Whiteboard: [qa-triaged]

Was not able to reproduce the issue at all by using Firefox 80.0, 80.0.1, Nightly 90.0a1 (2021-05-06) under both macOS 10.15.7 and Windows 10.

Jscher2000, could you verify please on latest builds if the issue is fixed for you? Thank you!

Flags: qe-verify+ → needinfo?(jscher2000)

(In reply to Catalin Sasca, QA [:csasca] from comment #13)

Was not able to reproduce the issue at all by using Firefox 80.0, 80.0.1, Nightly 90.0a1 (2021-05-06) under both macOS 10.15.7 and Windows 10.

Jscher2000, could you verify please on latest builds if the issue is fixed for you? Thank you!

Version 90.0b4 (DevEd) looks good.

Flags: needinfo?(jscher2000)

Thank you for verifying!

Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: