Closed Bug 1709975 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 28882 - [LayoutNG] Allow spanners inside a transform

Categories

(Core :: Layout: Columns, task, P4)

Product:
Core
Component:
Layout: Columns
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
90 Branch
Tracking Flags:
Tracking Status
firefox90 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 28882 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/28882
Details from upstream follow.

b'Alison Maher <almaher@microsoft.com>' wrote:

[LayoutNG] Allow spanners inside a transform

Previously, CanContainSpannerInParentFragmentationContext() would not
allow spanners that are the descendant of a transform. However, the
containing block chain now goes directly from the column spanner
to the multicol container for an NG multicol. Thus, it is safe to
allow a spanner to be a true column spanner if it is a descendant of
a transform (in the case that the multicol is an NG object).

Bug: 1196727
Change-Id: I908d4fdfc6ce090187dedbc2d9488b1c09bfa989
Reviewed-on: https://chromium-review.googlesource.com/2876245
WPT-Export-Revision: 5613a918a9fc8c3ec391dce929e984f0e229b678

Component: web-platform-tests → Layout: Columns
Product: Testing → Core

CI Results

Ran 15 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests

Status Summary

Firefox

PASS: 1

Chrome

FAIL: 1

Safari

PASS: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a08579636216
[wpt PR 28882] - [LayoutNG] Allow spanners inside a transform, a=testonly
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/13bf5d364a1b
[wpt PR 28882] - [LayoutNG] Allow spanners inside a transform, a=testonly
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/fb3c4f8ec623
[wpt PR 28882] - [LayoutNG] Allow spanners inside a transform, a=testonly

https://hg.mozilla.org/mozilla-central/rev/fb3c4f8ec623

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox90: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 90 Branch
You need to log in before you can comment on or make changes to this bug.