1709984 - Disable Snippets by Default in MR1

Status: VERIFIED FIXED

(Firefox :: New Tab Page, task)

Description

[Jim T]

New Default Pref Value:
browser.newtabpage.activity-stream.feeds.snippets = false

For More Context, See discussion and decision docs in https://jira.mozilla.com/browse/FIDE-469

Comment 1

[Mike de Boer [:mikedeboer]]

Amy, can you work on this bug this sprint? Quite likely we'll want this in 89.

Comment 2

[Amy Churchwell [:amy]]

(In reply to Mike de Boer [:mikedeboer] from comment #1)

Amy, can you work on this bug this sprint? Quite likely we'll want this in 89.

Yes, working on a patch today.

Comment 3

[Amy Churchwell [:amy]]

Attachment: Bug 1709984 - Disable snippets by default. r?thecount

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/eb2e067f5266
Disable snippets by default. r=k88hudson

Comment 5

[Amy Churchwell [:amy]]

Comment on attachment 9221229 [details]
Bug 1709984 - Disable snippets by default. r?thecount

Beta/Release Uplift Approval Request

• User impact if declined: There are several UX regressions (example: https://bugzilla.mozilla.org/show_bug.cgi?id=1703753) that impact snippets. Decision has been made to disable snippets by default to mitigate and improve newtab UX.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: 1. load about:newtab

2. fixed snippets banner at bottom of window should no longer be present.

• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Does not impact user functionality of newtab.
• String changes made/needed: N/A

Comment 6

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/eb2e067f5266

Comment 7

[Marius Coman [:mcoman], Ecosystem QA]

I have verified this task and I can confirm that the "Snippets" are no longer displayed by default on the "about:newtab" page and the browser.newtabpage.activity-stream.feeds.snippets pref is set to false in the "about:config" page.

Verified using the latest Firefox Nightly (90.0a1 Build ID - 20210513093303) installed on Windows 10 x64, macOS 10.15, and Linux Mint 20.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9221229 [details]
Bug 1709984 - Disable snippets by default. r?thecount

Approved for 89.0b12.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/65ceae7ba26a

Comment 10

[Marius Coman [:mcoman], Ecosystem QA]

I have verified this task and I can confirm that the "Snippets" are no longer displayed by default on the "about:newtab" page and the browser.newtabpage.activity-stream.feeds.snippets pref is set to false in the "about:config" page.

Verified using the latest Firefox Beta (89.0b12 Build ID - 20210513185752) installed on Windows 10 x64, macOS 10.15, and Linux Mint 20.