Closed Bug 1709984 Opened 1 month ago Closed 1 month ago

Disable Snippets by Default in MR1

Categories

(Firefox :: New Tab Page, task)

task

Tracking

()

VERIFIED FIXED
90 Branch
Tracking Status
firefox89 + verified
firefox90 + verified

People

(Reporter: jimthomas, Assigned: amy)

Details

Attachments

(1 file)

New Default Pref Value:
browser.newtabpage.activity-stream.feeds.snippets = false

For More Context, See discussion and decision docs in https://jira.mozilla.com/browse/FIDE-469

Amy, can you work on this bug this sprint? Quite likely we'll want this in 89.

Flags: needinfo?(achurchwell)
Assignee: nobody → achurchwell
Flags: needinfo?(achurchwell)

(In reply to Mike de Boer [:mikedeboer] from comment #1)

Amy, can you work on this bug this sprint? Quite likely we'll want this in 89.

Yes, working on a patch today.

Pushed by achurchwell@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/eb2e067f5266
Disable snippets by default. r=k88hudson

Comment on attachment 9221229 [details]
Bug 1709984 - Disable snippets by default. r?thecount

Beta/Release Uplift Approval Request

  • User impact if declined: There are several UX regressions (example: https://bugzilla.mozilla.org/show_bug.cgi?id=1703753) that impact snippets. Decision has been made to disable snippets by default to mitigate and improve newtab UX.
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: No
  • Needs manual test from QE?: Yes
  • If yes, steps to reproduce: 1. load about:newtab
  1. fixed snippets banner at bottom of window should no longer be present.
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Does not impact user functionality of newtab.
  • String changes made/needed: N/A
Attachment #9221229 - Flags: approval-mozilla-beta?
Flags: qe-verify+
Status: NEW → RESOLVED
Closed: 1 month ago
Resolution: --- → FIXED
Target Milestone: --- → 90 Branch
QA Whiteboard: [qa-triaged]

I have verified this task and I can confirm that the "Snippets" are no longer displayed by default on the "about:newtab" page and the browser.newtabpage.activity-stream.feeds.snippets pref is set to false in the "about:config" page.

Verified using the latest Firefox Nightly (90.0a1 Build ID - 20210513093303) installed on Windows 10 x64, macOS 10.15, and Linux Mint 20.

Status: RESOLVED → VERIFIED

Comment on attachment 9221229 [details]
Bug 1709984 - Disable snippets by default. r?thecount

Approved for 89.0b12.

Attachment #9221229 - Flags: approval-mozilla-beta? → approval-mozilla-beta+

I have verified this task and I can confirm that the "Snippets" are no longer displayed by default on the "about:newtab" page and the browser.newtabpage.activity-stream.feeds.snippets pref is set to false in the "about:config" page.

Verified using the latest Firefox Beta (89.0b12 Build ID - 20210513185752) installed on Windows 10 x64, macOS 10.15, and Linux Mint 20.

Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.