1709992 - Show the Quick/Firefox Suggest row at the end of the bookmarks/history group, not last

Status: VERIFIED FIXED

(Firefox :: Address Bar, task, P1)

Description

[Drew Willcoxon :adw]

The QS result has a suggestedIndex of -1, which means it always comes last. That was what we wanted before the Firefox Suggest label, but now that we have that, if you choose to show bookmarks/history before search suggestions, we show a Firefox Suggest label first and then an <engine> suggestions label, and then the QS at the end gets another Firefox Suggest label. The QS result should be in the bookmarks/history bucket instead.

Comment 1

[Drew Willcoxon :adw]

Attachment: Bug 1709992 - Show the Quick/Firefox Suggest row at the end of the general bucket.

This might be a little hacky because it builds special handling of quick suggest
results into the muxer instead of using some general solution. I have ideas for
general solutions, but they would all be larger than this patch, and we want to
uplift this to 89.

Comment 2

[Drew Willcoxon :adw]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=6a82e39c5d4e4314106f555c8e2219aa42817582

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f042a2548b4c
Show the Quick/Firefox Suggest row at the end of the general bucket. r=mak

Comment 4

[Drew Willcoxon :adw]

STR

1. Enable quick suggest
2. Open about:preferences#search and uncheck "Show search suggestions ahead of browsing history in address bar results"
3. Type something in the urlbar that shows both a quick suggest result and search suggestions, for example "amazon"
4. Verify that the Firefox Suggest section appears before the Google suggestions section
5. Verify that the quick suggest result appears last in the Firefox Suggest section

Comment 5

[Drew Willcoxon :adw]

Hi Cosmin, we'd like to uplift this if possible, so could you please prioritize verifying the fix once it's on Nightly? STR are in comment 4. Thank you.

Comment 6

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/f042a2548b4c

Comment 7

[Cosmin Muntean [:cmuntean], Ecosystem QA]

Hi Draw, thanks for the heads up! I have verified this bug on the latest Nightly 90.a01 build (Build ID: 20210511093339) on Windows 10 x64, macOS 10.15.7 and Ubuntu 20.04.

• In order to verify the issue I have used the STR provided in comment 4 and the quick suggest results appear last in the Firefox Suggest section.

• However, we have also performed exploratory testing and we have encountered a few bugs: Bug 1710648, Bug 1710650, Bug 1710654 and Bug 1710657. @Draw, when you have time can you please take a look over the new bugs?

Comment 8

[Drew Willcoxon :adw]

Thank you Cosmin! Of the four new bugs, I think bug 1710648 and bug 1710657 are the only ones that are truly caused by this bug. I left comments in the other two, but could you please test on an older Nightly to confirm my hunch that the other two are not related to this?

Bug 1710648 and bug 1710657 have the same root problem, so I think I can fix them together. The problem is that now that QS no longer has a suggested index, it doesn't get the flicker protection that it used to have.

Comment 9

[Drew Willcoxon :adw]

Comment on attachment 9220928 [details]
Bug 1709992 - Show the Quick/Firefox Suggest row at the end of the general bucket.

Beta/Release Uplift Approval Request

• User impact if declined: This will allow us to roll out phase 2 of Firefox Suggest to all en-US users on 89, not only those who have "Show search suggestions ahead of bookmarks and history" checked (the default). Without this, we'll have to wait until 90 to roll out phase 2 for users who have unchecked that preference. That would probably be OK, so this is more of a nice to have.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: Please see earlier comments in this bug (should be clear)
• List of other uplifts needed: Bug 1710648
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This is a targeted patch that only affects quick suggest results, which will only be enabled in phase 2 of the Firefox Suggest rollout.
• String changes made/needed:

Comment 10

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9220928 [details]
Bug 1709992 - Show the Quick/Firefox Suggest row at the end of the general bucket.

Approved for 89.0b13.

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/432a5ad86030

Comment 12

[Cosmin Muntean [:cmuntean], Ecosystem QA]

I have verified this issue on the latest Beta 89.0b13 on Windows 10 x64, macOS 10.15.7 and Linux Mint 20. In order to verify this issue, I have used the STR described in comment 4 and also performed exploratory testing. While performing exploratory testing, I have also covered the telemetry pings and found the following issue: Bug 1711449.