Closed Bug 1709998 Opened 2 years ago Closed 2 years ago

Do no change window size by PresentableSharedImage::PresentToWindow()

Categories

(Core :: Widget: Win32, enhancement)

Product:
Core
Component:
Widget: Win32
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
90 Branch
Tracking Flags:
Tracking Status
firefox89 --- wontfix
firefox90 --- fixed

People

(Reporter: sotaro, Assigned: sotaro)

References

(Blocks 1 open bug)

Details

(Whiteboard: [proton-foundations])

Attachments

(1 file)

Bug 1709998 - Do no change window size by PresentableSharedImage::PresentToWindow()
48 bytes, text/x-phabricator-request
Details | Review

PresentToWindow() calls UpdateLayeredWindow(). It set window size from size of mSharedImage. But there was a case that window size was already updated since mSharedImage creation.

In this case, window size was reverted to old size. And it caused a problem as in Bug 1701451 comment 22.

Blocks: 1701451
Assignee: nobody → sotaro.ikeda.g
Attachment #9220750 - Attachment description: WIP: Bug 1709998 - Do no change window size by PresentableSharedImage::PresentToWindow() → Bug 1709998 - Do no change window size by PresentableSharedImage::PresentToWindow()
See Also: → https://jira.mozilla.com/browse/FIDEFE-1680
Whiteboard: [proton-foundations]
Attachment #9220750 - Attachment description: Bug 1709998 - Do no change window size by PresentableSharedImage::PresentToWindow() → WIP: Bug 1709998 - Do no change window size by PresentableSharedImage::PresentToWindow()
Attachment #9220750 - Attachment description: WIP: Bug 1709998 - Do no change window size by PresentableSharedImage::PresentToWindow() → Bug 1709998 - Do no change window size by PresentableSharedImage::PresentToWindow()
Blocks: 1705085
Blocks: 1703741

I can confirm that this patch fixes bug 1701451 on my Windows 10 machine.

Pushed by sikeda.birchill@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8537afd2dcaa
Do no change window size by PresentableSharedImage::PresentToWindow() r=cmartin
Blocks: 1708446

https://hg.mozilla.org/mozilla-central/rev/8537afd2dcaa

Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox90: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 90 Branch
Blocks: 1709780

Should this be wontfix for 89 given that this fixes bug 1703741?

Flags: needinfo?(smohanty)
Blocks: sw-wr-popups
Flags: needinfo?(rtestard)

Pascal, can you please help assess risk here? I agree that this is desirable but also realize we're late in Beta cycle and have no idea about the risk that the patch could bring to 89.

Flags: needinfo?(rtestard) → needinfo?(pascalc)

Our last beta is tomorrow, bug 1703741 feels like an edge case (unfortunately it wasn't properly triaged and the bug has no severity set, but it feels to me not a big issue) and has no duplicate over the last month, I think we should let it ride the trains or take it in an 89 dot release if we realize that it would fix a more common bug discovered after shipping.

Flags: needinfo?(pascalc)

Thanks, OK let's leave the 'won't fix' flag.

Flags: needinfo?(smohanty)
You need to log in before you can comment on or make changes to this bug.