1709998 - Do no change window size by PresentableSharedImage::PresentToWindow()

Status: RESOLVED FIXED

(Core :: Widget: Win32, enhancement)

Description

[Sotaro Ikeda [:sotaro]]

PresentToWindow() calls UpdateLayeredWindow(). It set window size from size of mSharedImage. But there was a case that window size was already updated since mSharedImage creation.

In this case, window size was reverted to old size. And it caused a problem as in Bug 1701451 comment 22.

Comment 1

[Sotaro Ikeda [:sotaro]]

Attachment: Bug 1709998 - Do no change window size by PresentableSharedImage::PresentToWindow()

Comment 2

[Sotaro Ikeda [:sotaro]]

https://treeherder.mozilla.org/jobs?repo=try&revision=37f7a9540c5e65da85d01cfaabc8d555a2c8ccec

Comment 3

[Sotaro Ikeda [:sotaro]]

https://treeherder.mozilla.org/jobs?repo=try&revision=4b8c0bbaf9770d93d676cb3fe6ead068996a8e71

Comment 4

[Miko Mynttinen]

I can confirm that this patch fixes bug 1701451 on my Windows 10 machine.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8537afd2dcaa
Do no change window size by PresentableSharedImage::PresentToWindow() r=cmartin

Comment 6

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/8537afd2dcaa

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Should this be wontfix for 89 given that this fixes bug 1703741?

Comment 8

[Romain Testard [:RT]]

Pascal, can you please help assess risk here? I agree that this is desirable but also realize we're late in Beta cycle and have no idea about the risk that the patch could bring to 89.

Comment 9

[Pascal Chevrel:pascalc (PTO until April 26)]

Our last beta is tomorrow, bug 1703741 feels like an edge case (unfortunately it wasn't properly triaged and the bug has no severity set, but it feels to me not a big issue) and has no duplicate over the last month, I think we should let it ride the trains or take it in an 89 dot release if we realize that it would fix a more common bug discovered after shipping.

Comment 10

[Romain Testard [:RT]]

Thanks, OK let's leave the 'won't fix' flag.