1710010 - Collect telemetry for popup conditions

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, task, P2)

Description

[Tooru Fujisawa [:arai]]

In bug 1701001 and https://github.com/whatwg/html/pull/6530 , we're going to standardize the condition for opening popup by window.open.

Currently we're using the condition with a mix of Chrome's and Safari's behavior,
and the above bug/PR are going to standardize it with Safari's behavior.

To make sure the new condition doesn't introduce any compat issue on any browser,
we should verify the old/new conditions result in same "popup vs not-popup" in almost all cases.

Possible plan:

• Calculate isPopupRequested with old and new (and maybe Chrome's) conditions, and collect the number of "same" vs "different" cases
• optionally, if different, categorize the reason how/why they're different, and collect the number of them

Comment 1

[Tooru Fujisawa [:arai]]

(In reply to Tooru Fujisawa [:arai] from comment #0)

Possible plan:

• Calculate isPopupRequested with old and new (and maybe Chrome's) conditions, and collect the number of "same" vs "different" cases
• optionally, if different, categorize the reason how/why they're different, and collect the number of them

Given Chromium is collecting telemetry [1], and also assuming the window.open code can be per-browser,
I'll compare only current Firefox vs proposal.

[1] https://bugs.chromium.org/p/chromium/issues/detail?id=1192701#c9

Comment 2

[Tooru Fujisawa [:arai]]

Attachment: Bug 1710010 - Collect telemetry for popup condition of window.open. r?smaug!

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/94a8caf76b6e
Collect telemetry for popup condition of window.open. r=smaug

Comment 4

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/94a8caf76b6e