[tb perma] docshell/test/unit/test_subframe_stop_after_parent_error.js | xpcshell return code: 0
Categories
(Thunderbird :: Upstream Synchronization, defect, P5)
Tracking
(thunderbird91+ fixed)
People
(Reporter: intermittent-bug-filer, Assigned: darktrojan)
References
Details
(Keywords: intermittent-failure, Whiteboard: [stockwell disable-recommended])
Attachments
(1 file)
Filed by: mkmelin [at] iki.fi
Parsed log: https://treeherder.mozilla.org/logviewer?job_id=339057333&repo=comm-central
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/Xme1CfKFTUKesGqbwLgNww/runs/0/artifacts/public/logs/live_backing.log
Comment 1•3 years ago
|
||
Test just added in bug 1696473 - https://hg.mozilla.org/mozilla-central/rev/4a04508cbc61
Updated•3 years ago
|
Comment hidden (Intermittent Failures Robot) |
Comment 3•3 years ago
|
||
From https://treeherder.mozilla.org/logviewer?job_id=339254902&repo=comm-central&lineNumber=4362:
[task 2021-05-10T10:58:27.335Z] 10:58:27 INFO - PID 5142 | \x07[Parent 5142, Main Thread] ###!!! ASSERTION: Attempt to load a non-authorised load in the parent process: http://example.com/top.html: 'false', file /builds/worker/checkouts/gecko/netwerk/ipc/ParentProcessDocumentChannel.cpp:66
Comment hidden (Intermittent Failures Robot) |
Comment 5•3 years ago
|
||
The failing part of the test is testRemoveFrameAfterErrorPage which will not load the errorpage, just keep showing about:blank https://searchfox.org/mozilla-central/rev/048146721b3c1a568257afb4325c7a8d94334e2d/docshell/test/unit/test_subframe_stop_after_parent_error.js#114
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Assignee | ||
Comment 21•3 years ago
|
||
Kris is there anything we can do about this failure? It must be something to do with the config difference between Firefox and Thunderbird, but I can't figure out what. I do know that it goes away with browser.tabs.remote.autostart set to false, but that's hardly a solution.
Assignee | ||
Comment 22•3 years ago
|
||
If we can't find a solution this week I'd like to turn the test off for Thunderbird so we don't have to put up with it for an entire ESR cycle.
BTW if anyone's wondering why the failure count has dropped, we've largely given up marking it.
Comment hidden (Intermittent Failures Robot) |
Assignee | ||
Comment 24•3 years ago
|
||
I have very little hope of this test passing on Thunderbird before 91 moves to beta. Therefore I'm turning it off to reduce the noise on what will become comm-beta and comm-esr91.
Updated•3 years ago
|
Comment 25•3 years ago
|
||
(In reply to Geoff Lankow (:darktrojan) from comment #21)
Kris is there anything we can do about this failure? It must be something to do with the config difference between Firefox and Thunderbird, but I can't figure out what. I do know that it goes away with browser.tabs.remote.autostart set to false, but that's hardly a solution.
I believe that is the cause of this issue. Firefox always runs xpcshell tests with browser.tabs.remote.autostart = false
, even though we don't ship Firefox with e10s disabled.
Assignee | ||
Comment 26•3 years ago
|
||
Then I think all we can do is disable the test (or fix it to work with e10s). We can't stop Thunderbird tests running with the default preferences, and we can't override e10s in the manifest.
Comment 27•3 years ago
|
||
Alternatively the test could check browser.tabs.remote.autostart and bail out if it's true.
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment 30•3 years ago
|
||
Pushed by geoff@darktrojan.net: https://hg.mozilla.org/integration/autoland/rev/056ab3b94275 Disable test_subframe_stop_after_parent_error.js on Thunderbird until after 91. r=nika
Comment 31•3 years ago
|
||
Pushed by csabou@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/052cf3de0adb Fix syntax to unbust decision task. a=bustage-fix
Comment 32•3 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/056ab3b94275
https://hg.mozilla.org/mozilla-central/rev/052cf3de0adb
Assignee | ||
Updated•3 years ago
|
Assignee | ||
Comment 33•3 years ago
|
||
Comment on attachment 9230410 [details]
Bug 1710069 - Disable test_subframe_stop_after_parent_error.js on Thunderbird until after 91. r=kmag,nika
Beta/Release Uplift Approval Request
- User impact if declined: Just disables a test that fails when run in Thunderbird. We'd like to clear the failing test from TaskCluster so that failures we're actually concerned about aren't missed.
Please note that I screwed up the original patch so two changes landed.
- Is this code covered by automated tests?: Yes
- Has the fix been verified in Nightly?: No
- Needs manual test from QE?: No
- If yes, steps to reproduce:
- List of other uplifts needed: None
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky):
- String changes made/needed:
Comment 34•3 years ago
|
||
Comment on attachment 9230410 [details]
Bug 1710069 - Disable test_subframe_stop_after_parent_error.js on Thunderbird until after 91. r=kmag,nika
Low risk in early betas, approved for uplift in 91 beta 4, thanks
Comment 35•3 years ago
|
||
bugherder uplift |
Comment 36•3 years ago
|
||
backout bugherder uplift |
Build bustage with this error:
Intermittent manifestparser.expression.ParseError: could not parse: || appname == 'thunderbird'
https://hg.mozilla.org/releases/mozilla-beta/rev/faa5a9ebd3e1
Comment 37•3 years ago
|
||
It needs the follow-up patch as well: https://hg.mozilla.org/mozilla-central/rev/052cf3de0adb
Updated•3 years ago
|
Comment 38•3 years ago
|
||
bugherder uplift |
Assignee | ||
Updated•3 years ago
|
Comment hidden (Intermittent Failures Robot) |
Comment 40•3 years ago
|
||
Comment on attachment 9230410 [details]
Bug 1710069 - Disable test_subframe_stop_after_parent_error.js on Thunderbird until after 91. r=kmag,nika
Clearing the approval flag to get this off the needs-uplift radar.
Description
•