1710164 - White-on-white text on in-content pages when using macOS Dark Mode + High Contrast Mode, if widget.macos.respect-system-appearance is enabled

Status: VERIFIED FIXED

(Core :: Widget: Cocoa, defect, P2)

Description

[Markus Stange [:mstange]]

STR:

1. Set widget.macos.respect-system-appearance to true.
2. Enable macOS dark mode.
3. Enable "Increase contrast" in Accessibility.
4. Go to about:profiles.

Expected results:
White text and dark background.

Actual results:
White text and white background.

When "Increase contrast" is enabled, Firefox uses -moz-Dialog for the in-content page background. At the moment, -moz-Dialog resolves to rgba(255, 255, 255, 0.098) in dark mode. This is a very low-opacity white color, rather than an opaque dark color. It seems to be intended to be used on top of a dark backdrop.

Comment 1

[Harry Twyford]

I'm getting this on other in-content pages, like about:preferences, about:config, and about:sessionrestore.

Comment 2

[Harry Twyford]

Attachment: Bug 1710164 - Use appropriate system colors for in-content pages in HCM on macOS. r?#desktop-theme-reviewers!,mstange

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/56aa4be0522c
Use appropriate system colors for in-content pages in HCM on macOS. r=mstange,desktop-theme-reviewers,dao

Comment 4

[Noemi Erli[:noemi_erli]]

Backed out changeset 56aa4be0522c (Bug 1710164) for causing bustages in nsLookAndFeel.mm

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&collapsedPushes=842382&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=56aa4be0522c12a278dea513f518054500f90d3c&selectedTaskRun=N5xt_VZBQpeTWOrW7goB_w.0

Log: https://treeherder.mozilla.org/logviewer?job_id=342308808&repo=autoland&lineNumber=44933

Backout: https://hg.mozilla.org/integration/autoland/rev/00293b1648497346f790d2725fdafce3bcdad1a4

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3ec370f03e4d
Use appropriate system colors for in-content pages in HCM on macOS. r=mstange,desktop-theme-reviewers,dao

Comment 6

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/3ec370f03e4d

Comment 7

[Vlad Lucaci, Desktop QA (:vlucaci)]

Hello,

Managed to reproduce this issue on 90.0a(120210507095221), with macOS 11 device.

Confirming this issue as verified fixed on 90.0b8(20210615190254) and 91.0a1(20210617095423) using macOS 11 and macOS 10.15.7

Comment 8

[Mathew Hodson]

Are sure this is fixed on Firefox 90? The code fix only landed on Firefox 91 and wasn't uplifted. When you tested Firefox 90 did you set widget.macos.respect-system-appearance to true?

Comment 9

[Vlad Lucaci, Desktop QA (:vlucaci)]

Hello Mathew.

Yes I have set widget.macos.respect-system-appearance to true. and yes, this issue was only verified in 91.0a1(20210617095423).