1710191 - "New Message from Template" will change the security setting from "No Encryption" to "Encryption Required"

Status: RESOLVED FIXED

(MailNews Core :: Security: OpenPGP, defect)

Description

[EarlgreyTea]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1

Steps to Reproduce:

1. Start Thunderbird.
2. Open Tools > OpenPGP Key Manager, then do Generate > New Key Pair.
3. Open Preferences > Account Settings > (target account) > End-To-End Encryption.
4. Set to "Do not enable encryption by default".
5. Create a new message and make sure the security setting is set to "Do not encrypt".
6. Save it as template and close.
7. Select the template and do "New Message from Template".

Actual Results:

Compose window will open with "Require Encryption" setting.
Users who think they have it set to "No encryption" will be confused by the following error message if they send it as is.

Unable to send this message with end-to-end encryption, because there are problems with the keys of the following recipients: { $problem }

Expected Results:

As with editing templates and drafts, the security settings should not be changed.
That should be left up to users.
If there is a reason for the current behavior, I would like to see an error message asking the user to check their security settings.

Comment 1

[Magnus Melin [:mkmelin]]

Confirmed.

Comment 2

[Harald Judt]

Confirmed. This is very annoying when using templates. I usually only want to digitally sign my messages, not encrypt them. Each time I create a new message from a template, I need to tick off that encryption setting.

Comment 3

[Magnus Melin [:mkmelin]]

Attachment: Bug 1710191 - make mail/test/browser/openpgp/browser_keyWizard.js clean up properly. r=lasana

Wasn't passing with --verify.

Comment 4

[Magnus Melin [:mkmelin]]

Attachment: Bug 1710191 - templates should not be set to use Require Encryption just because they were stored encrypted. r=lasana

Depends on D118705

Comment 5

[Lasana Murray]

Note: This does not happen if you right click on "New Message from Template" without first left clicking on the message and bringing up the preview.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/65144b30e7f4
make mail/test/browser/openpgp/browser_keyWizard.js clean up properly. r=lasana
https://hg.mozilla.org/comm-central/rev/e6f38b95a7c8
templates should not be set to use Require Encryption just because they were stored encrypted. r=lasana