Toolbarbuttons with light themes that don't define border colours have no border on hover
Categories
(Thunderbird :: Theme, defect)
Tracking
(thunderbird_esr78 unaffected, thunderbird89 fixed)
Tracking | Status | |
---|---|---|
thunderbird_esr78 | --- | unaffected |
thunderbird89 | --- | fixed |
People
(Reporter: Paenglab, Assigned: Paenglab)
References
(Regression)
Details
(Keywords: regression)
Attachments
(1 file)
2.48 KB,
patch
|
aleca
:
review+
wsmwk
:
approval-comm-beta+
|
Details | Diff | Splinter Review |
After bug 1691297 the toolbarbutton-1 don't have a visible border with light themes that don't define a border colour like the "Thunderbird Suave" theme.
Assignee | ||
Comment 1•4 years ago
|
||
This comes from the background-clip: padding-box;
we have defined. Until bug 1691297 we overwrite this on hover with using background: ...
. Now we have only set the background-color and the background-clip is still used. Removing it fixes this by always using border-box
.
I also changed on menulist the background:
to background-color
.
Comment 2•3 years ago
|
||
We could potentially get this in b4 with bug 1691297
Comment 3•3 years ago
|
||
Assignee | ||
Comment 4•3 years ago
|
||
(In reply to Alessandro Castellani [:aleca] from comment #3)
Comment on attachment 9220944 [details] [diff] [review]
1710214-no-toolbarbutton-1-padding-box.patchReview of attachment 9220944 [details] [diff] [review]:
This seems good, thanks.
Why we had thebackground-clip: padding-box;
attribute? What was it used
for?
No more sure but I think this was when we used gradients to not paint into the border.
In general I'm all for being attribute specific when updated background by
using only the color, but are you sure that with this change we're not gonna
have any regressions if some elements use a background-image attribute?
When there was a rule that used background-image it wouldn't have applied because of the background: rules we used for the hover state.
Assignee | ||
Comment 5•3 years ago
|
||
Comment on attachment 9220944 [details] [diff] [review]
1710214-no-toolbarbutton-1-padding-box.patch
[Approval Request Comment]
Regression caused by (bug #): bug 1691297
User impact if declined: not correct drawn toolbar buttons with light themes
Testing completed (on c-c, etc.): soon on c-c
Risk to taking this patch (and alternatives if risky): low
Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/e37008cded84
Remove the padding-box from the toolbarbutton-1. r=aleca
Comment 7•3 years ago
|
||
Comment on attachment 9220944 [details] [diff] [review]
1710214-no-toolbarbutton-1-padding-box.patch
[Triage Comment]
Approved for beta
Updated•3 years ago
|
Comment 8•3 years ago
|
||
bugherder uplift |
Thunderbird 89.0b4:
https://hg.mozilla.org/releases/comm-beta/rev/b106f57103e3
Description
•