1710233 - Move statusbar code from menus.xul to chatzilla.xul

Status: RESOLVED FIXED

(SeaMonkey :: Chat, task)

Description

[Ian Neal]

The current code makes use of eventlisteners for clicks on various parts of the statusbar in cZ, we should switch to doing it in the same way as the statusbar in the rest of SeaMonkey. Also tidy up some the code whilst we are here.

Comment 1

[Ian Neal]

Attachment: 1710233-irc-move-statusbar-2539.patch

[Approval Request Comment]
Regression caused by (bug #): n/a
User impact if declined: none
Testing completed (on m-c, etc.): 2.53.8
Risk to taking this patch (and alternatives if risky): low
String changes made by this patch: none

With this patch the irc server you are connected is displayed whether it is secure or not. The side effect is that if you click on the insecure server name in the status bar it pops up an alert saying it is not a secure connection. Perhaps that behaviour / message needs changing.

Comment 2

[Kadir Selçuk]

(In reply to Ian Neal from comment #0)

The current code makes use of eventlisteners for clicks on various parts of the statusbar in cZ, we should switch to doing it in the same way as the statusbar in the rest of SeaMonkey. Also tidy up some the code whilst we are here.

Comment 3

[Frank-Rainer Grahl (:frg)]

Comment on attachment 9220969 [details] [diff] [review]
1710233-irc-move-statusbar-2539.patch

LGTM

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/78f673ce1edc
Move statusbar code from menus.xul to chatzilla.xul. r=frg

Comment 5

[Frank-Rainer Grahl (:frg)]

https://gitlab.com/seamonkey-project/seamonkey-2.53-comm/-/commit/987cedd58ce0aff3758711bb768ec5a631a9473c
Move statusbar code from menus.xul to chatzilla.xul. r=frg a=frg