Closed Bug 1710233 Opened 5 months ago Closed 3 months ago

Move statusbar code from menus.xul to chatzilla.xul

Categories

(SeaMonkey :: Chat, task)

Tracking

(seamonkey2.53+ fixed)

RESOLVED FIXED
seamonkey 2.88
Tracking Status
seamonkey2.53 + fixed

People

(Reporter: iann_bugzilla, Assigned: iann_bugzilla)

References

Details

(Whiteboard: SM2.53.9)

Attachments

(1 file)

The current code makes use of eventlisteners for clicks on various parts of the statusbar in cZ, we should switch to doing it in the same way as the statusbar in the rest of SeaMonkey. Also tidy up some the code whilst we are here.

[Approval Request Comment]
Regression caused by (bug #): n/a
User impact if declined: none
Testing completed (on m-c, etc.): 2.53.8
Risk to taking this patch (and alternatives if risky): low
String changes made by this patch: none

With this patch the irc server you are connected is displayed whether it is secure or not. The side effect is that if you click on the insecure server name in the status bar it pops up an alert saying it is not a secure connection. Perhaps that behaviour / message needs changing.

Attachment #9220969 - Flags: review?(frgrahl)
Attachment #9220969 - Flags: approval-comm-release?
Attachment #9220969 - Flags: approval-comm-esr60?
Blocks: 1710238
Whiteboard: SM2.53.9
Flags: needinfo?(post.kadirselcuk)
Flags: needinfo?(post.kadirselcuk)
Flags: needinfo?(post.kadirselcuk)

Comment on attachment 9220969 [details] [diff] [review]
1710233-irc-move-statusbar-2539.patch

LGTM

Attachment #9220969 - Flags: review?(frgrahl)
Attachment #9220969 - Flags: review+
Attachment #9220969 - Flags: approval-comm-release?
Attachment #9220969 - Flags: approval-comm-release+
Attachment #9220969 - Flags: approval-comm-esr60?
Attachment #9220969 - Flags: approval-comm-esr60+

Pushed by frgrahl@gmx.net:
https://hg.mozilla.org/comm-central/rev/78f673ce1edc
Move statusbar code from menus.xul to chatzilla.xul. r=frg

Status: ASSIGNED → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey 2.88
You need to log in before you can comment on or make changes to this bug.