Closed Bug 1710250 Opened 5 months ago Closed 3 months ago

Switch to using Services.obs in chatZilla

Categories

(SeaMonkey :: Chat, task)

Tracking

(seamonkey2.53+ fixed)

RESOLVED FIXED
seamonkey 2.88
Tracking Status
seamonkey2.53 + fixed

People

(Reporter: iann_bugzilla, Assigned: iann_bugzilla)

Details

(Whiteboard: SM2.53.9)

Attachments

(1 file)

Make use of Services.obs in chatZilla and whilst here port the changes from Bug 1356569 for Services.obs

[Approval Request Comment]
Regression caused by (bug #): n/a
User impact if declined: none
Testing completed (on m-c, etc.): 2.53.8
Risk to taking this patch (and alternatives if risky): low
String changes made by this patch: none

Attachment #9220985 - Flags: review?(frgrahl)
Attachment #9220985 - Flags: approval-comm-release?
Attachment #9220985 - Flags: approval-comm-esr60?
Whiteboard: SM2.53.9

Comment on attachment 9220985 [details] [diff] [review]
1710250-irc-obs-2539.patch

LGTM.

I think I have seem removeObserver to throw if the addObserver did not happen but so far have not seen it here. So the try/catch can go for now I think.

Attachment #9220985 - Flags: review?(frgrahl)
Attachment #9220985 - Flags: review+
Attachment #9220985 - Flags: approval-comm-release?
Attachment #9220985 - Flags: approval-comm-release+
Attachment #9220985 - Flags: approval-comm-esr60?
Attachment #9220985 - Flags: approval-comm-esr60+

Pushed by frgrahl@gmx.net:
https://hg.mozilla.org/comm-central/rev/7458032c4b69
Switch to using Services.obs in chatZilla. r=frg

Status: ASSIGNED → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey 2.88
You need to log in before you can comment on or make changes to this bug.