Uncaught TypeError: ChromeUtils.getClassName: Argument 1 is not an object. specialTabs.js:716:2
Categories
(Thunderbird :: General, defect)
Tracking
(thunderbird_esr78 wontfix)
Tracking | Status | |
---|---|---|
thunderbird_esr78 | --- | wontfix |
People
(Reporter: alta88, Assigned: alta88)
Details
Attachments
(1 file, 1 obsolete file)
1.81 KB,
patch
|
darktrojan
:
review+
|
Details | Diff | Splinter Review |
Error cases won't necessarily have the required arg as an object.
Comment 2•3 years ago
|
||
Comment on attachment 9220987 [details] [diff] [review]
getClassName.patch
instanceof
doesn't use strings on the right-hand side.
I'd rather you left GlobalPopupNotifications.jsm alone, as it's a copy of Firefox code and every modification we make makes it harder to fix when they inevitably break things.
(In reply to Geoff Lankow (:darktrojan) from comment #2)
Comment on attachment 9220987 [details] [diff] [review]
getClassName.patch
instanceof
doesn't use strings on the right-hand side.
uff, sorry.
I'd rather you left GlobalPopupNotifications.jsm alone, as it's a copy of Firefox code and every modification we make makes it harder to fix when they inevitably break things.
sure, that's legitimate.
Updated•3 years ago
|
Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/db24a1df916d
Use instanceof to test nodes instead of getClassName(). r=darktrojan
Updated•3 years ago
|
Updated•3 years ago
|
Description
•