Closed Bug 1710255 Opened 3 years ago Closed 3 years ago

Uncaught TypeError: ChromeUtils.getClassName: Argument 1 is not an object. specialTabs.js:716:2

Categories

(Thunderbird :: General, defect)

defect

Tracking

(thunderbird_esr78 wontfix)

RESOLVED FIXED
90 Branch
Tracking Status
thunderbird_esr78 --- wontfix

People

(Reporter: alta88, Assigned: alta88)

Details

Attachments

(1 file, 1 obsolete file)

No description provided.
Attached patch getClassName.patch (obsolete) — Splinter Review

Error cases won't necessarily have the required arg as an object.

Assignee: nobody → alta88
Attachment #9220987 - Flags: review?(geoff)

Comment on attachment 9220987 [details] [diff] [review]
getClassName.patch

instanceof doesn't use strings on the right-hand side.

I'd rather you left GlobalPopupNotifications.jsm alone, as it's a copy of Firefox code and every modification we make makes it harder to fix when they inevitably break things.

Attachment #9220987 - Flags: review?(geoff) → review-

(In reply to Geoff Lankow (:darktrojan) from comment #2)

Comment on attachment 9220987 [details] [diff] [review]
getClassName.patch

instanceof doesn't use strings on the right-hand side.

uff, sorry.

I'd rather you left GlobalPopupNotifications.jsm alone, as it's a copy of Firefox code and every modification we make makes it harder to fix when they inevitably break things.

sure, that's legitimate.

Attachment #9220987 - Attachment is obsolete: true
Attachment #9221247 - Flags: review?(geoff)
Attachment #9221247 - Flags: review?(geoff) → review+

Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/db24a1df916d
Use instanceof to test nodes instead of getClassName(). r=darktrojan

Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 90 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: